Add mypy_extensions. #611
Merged
Add mypy_extensions. #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
reviewed
Oct 16, 2016
| T = TypeVar('T') | ||
|
|
||
|
|
||
| def TypedDict(typename: str, fields: Dict[str, Type[T]]) -> Type[dict]: ... |
There was a problem hiding this comment.
Hm, I thought the design for TypeDict allowed it to be used with keyword args?
There was a problem hiding this comment.
It's not supported in the current implementation so far, but yes it's in the design.
I have a line item pending to discuss some forward compatibility concerns with keyword args (**kwfields) before actually implementing it.
|
OK, let's wait until we've discussed that then.
|
|
Actually it's better to merge this before merging python/mypy#2206, so I've done that now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports pending PR python/mypy#2206 .