Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a python 3.7+ version of Annotated to typing_extensions (#1014) #632

Merged
merged 7 commits into from May 27, 2019
Merged

Add a python 3.7+ version of Annotated to typing_extensions (#1014) #632

merged 7 commits into from May 27, 2019

Conversation

till-varoquaux
Copy link
Contributor

@till-varoquaux till-varoquaux commented May 23, 2019

First commits for PEP 593..

Copy link
Collaborator

@ilevkivskyi ilevkivskyi left a comment

Thanks for quick implementation! This looks good. I have some suggestions (mostly minor and stylistic).

Shouldn't this also add a "patched" version of get_type_hints() that would work as described in the PEP?

typing_extensions/src_py3/typing_extensions.py Outdated Show resolved Hide resolved
typing_extensions/src_py3/typing_extensions.py Outdated Show resolved Hide resolved
typing_extensions/src_py3/typing_extensions.py Outdated Show resolved Hide resolved
typing_extensions/src_py3/typing_extensions.py Outdated Show resolved Hide resolved
typing_extensions/src_py3/typing_extensions.py Outdated Show resolved Hide resolved
@till-varoquaux
Copy link
Contributor Author

@till-varoquaux till-varoquaux commented May 24, 2019

Since I'm new to this code base I'm proceeding very incrementally. The get_type_hints diffs will come in a separate batch.

Copy link
Collaborator

@ilevkivskyi ilevkivskyi left a comment

Great! I have few more small comments, otherwise this is ready to be merged.

@till-varoquaux
Copy link
Contributor Author

@till-varoquaux till-varoquaux commented May 27, 2019

Ok, we should be ready to go! Thank you Ivan and Jakub for your all of your feedback. If you want I can squash all of those commits before we merge this request.

@ilevkivskyi ilevkivskyi merged commit 3a50379 into python:master May 27, 2019
1 check passed
@ilevkivskyi
Copy link
Collaborator

@ilevkivskyi ilevkivskyi commented May 27, 2019

We always squash ourselves, please don't do this.

You can now post in the PEP discussion thread and propose people to try this out and play with it (one can install the library direcrly from GitHub).

jstasiak added a commit to jstasiak/typeshed that referenced this issue Oct 15, 2019
The code has been added to typing_extensions in
python/typing#632 and
python/typing#639.

I really didn't know how to type Annotated and _AnnotatedAlias here –
feel free to correct this.
JelleZijlstra pushed a commit to python/typeshed that referenced this issue Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants