Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting #875

Merged
merged 4 commits into from Aug 30, 2021
Merged

Fix linting #875

merged 4 commits into from Aug 30, 2021

Conversation

@srittau
Copy link
Collaborator

@srittau srittau commented Aug 30, 2021

  • Split linting against implementation and tests into two steps.
  • Add more error codes for test linting.
  • Lint with Python 3.9.
  • Fix a linting problem.

Ideally, we'd have just one configuration for linting both the implementation and tests.

@srittau srittau changed the title Split linting into two steps Fix linting Aug 30, 2021
@srittau srittau marked this pull request as ready for review Aug 30, 2021
@JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Aug 30, 2021

There's another 3.10 CI issue, one that I didn't see locally.

@srittau
Copy link
Collaborator Author

@srittau srittau commented Aug 30, 2021

If I understand correctly, this is not really a 3.10 problem, but a CI problem. CI shouldn't run the typing tests for 3.10, only the typing_extension tests. Working on it.

@srittau srittau merged commit 68e7cb7 into python:master Aug 30, 2021
8 of 9 checks passed
@srittau srittau deleted the fix-linting branch Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants