Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up typing_extensions -- typing_extensions #932

Merged
merged 32 commits into from Nov 11, 2021

Conversation

@AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Nov 10, 2021

xref #892
@srittau

Actual typing_extensions PR. Unchanged from original.

A

Copy link
Collaborator

@srittau srittau left a comment

Thanks!

You (sensibly) removed a few non-underscored, but also not exported via __all__ attributes. As this is technically an API change (even though it's not exported via __all__), could you add these removals to typing_extensions/CHANGELOG:

  • TypingMeta
  • OLD_GENERICS
  • SUBS_TREE
  • HAVE_ANNOTATED
  • HAVE_PROTOCOLS

Also could you mention in the Changelog that starting with 4.0.0 support for Python 2 and <3.6 has been dropped?

A few more remarks below.

typing_extensions/src_py3/typing_extensions.py Outdated Show resolved Hide resolved
typing_extensions/src_py3/typing_extensions.py Outdated Show resolved Hide resolved
typing_extensions/src_py3/typing_extensions.py Outdated Show resolved Hide resolved
@AA-Turner AA-Turner force-pushed the cleanup-typing-extensions branch from de58c57 to 5d75e5f Nov 11, 2021
@AA-Turner AA-Turner force-pushed the cleanup-typing-extensions branch from 5d75e5f to 12ec8de Nov 11, 2021
@AA-Turner
Copy link
Member Author

@AA-Turner AA-Turner commented Nov 11, 2021

Sorry, forgot to add a changelog entry earlier -- have now done so.

Copy link
Collaborator

@srittau srittau left a comment

Thanks again. For future reference: Please don't force push as it makes it harder to review changes.

@AA-Turner
Copy link
Member Author

@AA-Turner AA-Turner commented Nov 11, 2021

Sorry - I had to rebase onto master to pick up the changelog -- is it better to merge in HEAD instead of rebase + force push?
A

@srittau srittau merged commit 6992984 into python:master Nov 11, 2021
7 checks passed
@srittau
Copy link
Collaborator

@srittau srittau commented Nov 11, 2021

Yes, we squash merge anyway, so rebasing should not be necessary.

@srittau srittau mentioned this pull request Nov 11, 2021
@AA-Turner AA-Turner deleted the cleanup-typing-extensions branch Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants