From 619dae1be991eabdf0f0f76c491135a75d7a5b9b Mon Sep 17 00:00:00 2001 From: Shivani Arbat Date: Sat, 22 Apr 2023 14:59:48 -0600 Subject: [PATCH 1/2] #1695 fixed : Tiles that were rotated in Tiled have wrong hitbox --- arcade/texture/transforms.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arcade/texture/transforms.py b/arcade/texture/transforms.py index e1f165156..8ebd82dae 100644 --- a/arcade/texture/transforms.py +++ b/arcade/texture/transforms.py @@ -189,7 +189,7 @@ def transform_hit_box_points( points: PointList, ) -> PointList: points = FlipLeftRightTransform.transform_hit_box_points(points) - points = Rotate270Transform.transform_hit_box_points(points) + points = Rotate90Transform.transform_hit_box_points(points) return points @@ -209,7 +209,7 @@ def transform_hit_box_points( points: PointList, ) -> PointList: points = FlipLeftRightTransform.transform_hit_box_points(points) - points = Rotate90Transform.transform_hit_box_points(points) + points = Rotate270Transform.transform_hit_box_points(points) return points From 6d558eb39bbc6e0add17eba66d0f786d9c7daa27 Mon Sep 17 00:00:00 2001 From: Shivani Arbat Date: Sat, 22 Apr 2023 15:14:01 -0600 Subject: [PATCH 2/2] #1695 fixed broken unit tests : Tiles that were rotated in Tiled have wrong hitbox --- tests/unit/texture/test_texture_transform_values.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/unit/texture/test_texture_transform_values.py b/tests/unit/texture/test_texture_transform_values.py index ab4d54149..31cb054eb 100644 --- a/tests/unit/texture/test_texture_transform_values.py +++ b/tests/unit/texture/test_texture_transform_values.py @@ -91,7 +91,7 @@ def test_flip_top_bottom_transform(): def test_transpose_transform(): # Transpose result = TransposeTransform.transform_hit_box_points(HIT_BOX_POINTS) - assert result == ((-64.0, -64.0), (-64.0, 64.0), (64.0, 64.0), (64.0, -64.0)) + assert result == ((64.0, 64.0), (64.0, -64.0), (-64.0, -64.0), (-64.0, 64.0)) # Flip back result = TransposeTransform.transform_hit_box_points(result) assert result == HIT_BOX_POINTS @@ -106,7 +106,7 @@ def test_transpose_transform(): def test_transverse_transform(): # Transverse result = TransverseTransform.transform_hit_box_points(HIT_BOX_POINTS) - assert result == ((64.0, 64.0), (64.0, -64.0), (-64.0, -64.0), (-64.0, 64.0)) + assert result == ((-64.0, -64.0), (-64.0, 64.0), (64.0, 64.0), (64.0, -64.0)) # Flip back result = TransverseTransform.transform_hit_box_points(result) assert result == HIT_BOX_POINTS