diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 36ac57c3e..cc583c5da 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -31,12 +31,21 @@ jobs: run: | python -m pip install -U pip wheel setuptools - name: wheel + id: wheel run: | python -m pip install -e .[dev] - - name: code-inspection + - name: "code-inspection: mypy" + if: ${{ (success() || failure()) && steps.wheel.outcome == 'success' }} run: | - mypy arcade - ruff arcade + python ./make.py mypy + - name: "code-inspection: pyright" + if: ${{ (success() || failure()) && steps.wheel.outcome == 'success' }} + run: | + python ./make.py pyright + - name: "code-inspection: ruff" + if: ${{ (success() || failure()) && steps.wheel.outcome == 'success' }} + run: | + python ./make.py ruff - name: build-docs run: | sphinx-build doc build -W diff --git a/arcade/cache/texture.py b/arcade/cache/texture.py index 3df7e83a2..b45a12199 100644 --- a/arcade/cache/texture.py +++ b/arcade/cache/texture.py @@ -91,13 +91,13 @@ def put( name = texture.cache_name if strong: self._strong_entries.put(name, texture) - if self._strong_file_entries.get(file_path): + if self._strong_file_entries.get(file_path): # type: ignore # pending https://github.com/pythonarcade/arcade/issues/1752 raise ValueError(f"File path {file_path} already in cache") if file_path: self._strong_file_entries.put(str(file_path), texture) else: self._weak_entires.put(name, texture) - if self._weak_file_entries.get(file_path): + if self._weak_file_entries.get(file_path): # type: ignore # pending https://github.com/pythonarcade/arcade/issues/1752 raise ValueError(f"File path {file_path} already in cache") if file_path: self._weak_file_entries.put(str(file_path), texture) diff --git a/make.py b/make.py index 50551b356..26f438f2d 100755 --- a/make.py +++ b/make.py @@ -427,10 +427,11 @@ def pseudoxml(): @app.command(rich_help_panel="Code Quality") def lint(): """ - Run all linting tasks: ruff and mypy (Run this before making a pull request!) + Run all linting tasks: ruff, mypy, and pyright (Run this before making a pull request!) """ ruff() mypy() + pyright() print("Linting Complete.")