From 795d06f947b3196f8b453ae2cc7ba45123505c8f Mon Sep 17 00:00:00 2001
From: pushfoo <36696816+pushfoo@users.noreply.github.com>
Date: Thu, 26 Oct 2023 00:37:02 -0400
Subject: [PATCH] Use 3.12's buffer protocol annotation if available

* Import the new Buffer protocol type on Python >= 3.12

* Explain why the typing_extensions stub is worse for arcade than a Union
---
 arcade/types.py | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/arcade/types.py b/arcade/types.py
index 64c4a99ce..f904c5b2f 100644
--- a/arcade/types.py
+++ b/arcade/types.py
@@ -5,6 +5,7 @@
 
 from __future__ import annotations
 
+import sys
 from array import array
 import ctypes
 import random
@@ -449,11 +450,11 @@ class TiledObject(NamedTuple):
     type: Optional[str] = None
 
 
-# This is a temporary workaround for the lack of a way to type annotate
-# objects implementing the buffer protocol. Although there is a PEP to
-# add typing, it is scheduled for 3.12. Since that is years away from
-# being our minimum Python version, we have to use a workaround. See
-# the PEP and Python doc for more information:
-# https://peps.python.org/pep-0688/
-# https://docs.python.org/3/c-api/buffer.html
-BufferProtocol = Union[ByteString, memoryview, array, ctypes.Array]
+if sys.version_info >= (3, 12):
+    from collections.abc import Buffer as BufferProtocol
+else:
+    # This is used instead of the typing_extensions version since they
+    # use an ABC which registers virtual subclasses. This will not work
+    # with ctypes.Array since virtual subclasses must be concrete.
+    # See: https://peps.python.org/pep-0688/
+    BufferProtocol = Union[ByteString, memoryview, array, ctypes.Array]