InputManager - Check if Controller device is open before opening #2779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, the `__init__` of the `InputManager` could fail if a controller had already been open. This could occur if an `InputManager` was instantiated twice. This commit closes issue pythonarcade#2778.
|
Looks good, I thought about potentially having the InputManager close the controller it's responsible for, but that seems like it'd be inflexible and just create more problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this merge, the
__init__of theInputManagercould fail if a controller had already been open. This could occur if anInputManagerwas instantiated twice, see #2778.This commit closes issue #2778.