-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
better_combos: encoded url and substring not found #332
Comments
yes,it works. Adding 'name = parse.unquote(name)' after 'name = request.match_info["name"]' |
I opened this up in vscode to search for all instances of |
Harley as And huh
…On Tue, Sep 10, 2024 at 10:33 AM Jeff Bluemel ***@***.***> wrote:
yes,it works. Adding 'name = parse.unquote(name)' after 'name =
request.match_info["name"]'
I opened this up in vscode, implemented this fix in multiple places, and
it did fix all the issues I'm having. Thanks :)
—
Reply to this email directly, view it on GitHub
<#332 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BE7VXHI6OAWQMZME6GHU6ZTZV37MDAVCNFSM6AAAAABNOMJUVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBRGAYTKNRSGQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***
com>
|
For those coming across this issue, this solution worked for me as well, I'll try to explain the solution in a bit more detail for those who aren't as well versed in modifying python code (like me). Go to this folder ...\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Custom-Scripts\py At the top of each file there will be text like this:
At the end add this text: it should look like this:
Then in each document look for all places where you can find these lines (you can use your text editors search function or just have a look yourself):
In between these lines add:
There is 4 places this text needs to be added in "better_combos.py", and 2 places in "model_info.py". Save each file when your done and next time you boot up ComfyUI this issue should hopefully be resolved. |
Is this caused by a comfy update or sth? |
Referring to some other discussion, it is caused by comfy update. |
Doing this does indeed "fix" the issue... technically...... however this seems to change the model's file format if you do so._ I followed the steps exactly, and it results in model file formats all being changed to ".sha256" for whatever reason? EDIT: Okay after restarting the program suddenly it works? Bruh... no idea why it was giving me an error about the format being wrong, which I sadly didnt keep track of what it has said, but it led me to believe it was due to the file format changing. But it would seem that it actually just created a new file, not replacing the file, my mistake. |
Glad it helped, not sure what exactly happened in your case but I know that whenever you use the lora loader or the checkpoint loader to check the info for a file it will generate a .sha256 file with the same name as the lora / checkpoint in the same folder. I'm guessing this is a file that these custom nodes use to store extra information in. |
Just confirming this worked for me too. Thank you. |
Whan add the
Lora Loader
node, the console will hintsubstring not found
error.Browser: Firefox 130.0b9 on Windows
The problem is the variable
name
is encoded uri that mean the/
will be encoded to%2F
. We should callurllib.parse.unquote
before find the index of/
.The text was updated successfully, but these errors were encountered: