E-Mail Notification Base Framework #21

Closed
wants to merge 20 commits into
from

Conversation

Projects
None yet
2 participants
@K-7

K-7 commented Dec 20, 2014

E-Mail Notification Base Framework

junction/custom_utils/emailer.py
+
+ to_list = content['to_email']
+
+ FROM_ADDRESS = content.get('from_email', default=None)

This comment has been minimized.

@sivaa

sivaa Dec 20, 2014

Contributor

from_address

@sivaa

sivaa Dec 20, 2014

Contributor

from_address

junction/custom_utils/emailer.py
+ to_list = content['to_email']
+
+ FROM_ADDRESS = content.get('from_email', default=None)
+ if FROM_ADDRESS == None:

This comment has been minimized.

@sivaa

sivaa Dec 20, 2014

Contributor

if from_address is None:

@sivaa

sivaa Dec 20, 2014

Contributor

if from_address is None:

junction/custom_utils/emailer.py
+ message.set_from(FROM_ADDRESS)
+
+ cc_list = content.get('cc_email', default=None)
+ if cc_list != None:

This comment has been minimized.

@sivaa

sivaa Dec 20, 2014

Contributor

if cc_list is not None

@sivaa

sivaa Dec 20, 2014

Contributor

if cc_list is not None

junction/junction/settings.py
+SENDGRID_EMAIL_PORT = 587
+SENDGRID_EMAIL_USERNAME = "SENDGRID_USERNAME"
+SENDGRID_EMAIL_PASSWORD = "SENDGRID_PASSWORD"
+SENDGRID_FROM_EMAIL = "DEFAULT_FROM_EMAIL"

This comment has been minimized.

@sivaa

sivaa Dec 20, 2014

Contributor

For username, password and from_email, read it from environment variables

@sivaa

sivaa Dec 20, 2014

Contributor

For username, password and from_email, read it from environment variables

@sivaa

This comment has been minimized.

Show comment
Hide comment
@sivaa

sivaa Jan 8, 2015

Contributor

The build is failing. Can you please fix it and send the new PR?

Contributor

sivaa commented Jan 8, 2015

The build is failing. Can you please fix it and send the new PR?

@sivaa sivaa closed this Jan 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment