feat(frontend/proposal_list): add content uploaded status #250

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
4 participants
@umulingu

closes #242

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 16, 2015

Coverage Status

Coverage remained the same at 59.6% when pulling 0ee9242 on umulingu:devjunction into 51e262a on pythonindia:master.

Coverage Status

Coverage remained the same at 59.6% when pulling 0ee9242 on umulingu:devjunction into 51e262a on pythonindia:master.

@theskumar

This comment has been minimized.

Show comment
Hide comment
@theskumar

theskumar May 16, 2015

Member

@umulingu possible to upload a screenshot for your change here, please?

Member

theskumar commented May 16, 2015

@umulingu possible to upload a screenshot for your change here, please?

@theskumar theskumar changed the title from Devjunction to feat(frontend/proposal_list): add content uploaded status May 16, 2015

@@ -91,7 +91,7 @@
</div>
{% if proposals_to_review %}
- {% include 'proposals/partials/proposal-list--items.html' with proposals=proposals_to_review title="Proposals To Be Reviewed" display_status=False %}
+ {% include 'proposals/partials/proposal-list--items.html' with proposals=proposals_to_review title="Proposals To Be Reviewed" display_status=False content_status=True %}

This comment has been minimized.

@theskumar

theskumar May 16, 2015

Member

This is always content_status is always going to be true, wondering why would you like to do something like this. You need implement actual logic for detecting content uploaded or not.

@theskumar

theskumar May 16, 2015

Member

This is always content_status is always going to be true, wondering why would you like to do something like this. You need implement actual logic for detecting content uploaded or not.

This comment has been minimized.

@umulingu

umulingu May 18, 2015

@theskumar
Because we have to display content status for "proposals to review" tab only.

@umulingu

umulingu May 18, 2015

@theskumar
Because we have to display content status for "proposals to review" tab only.

This comment has been minimized.

@ChillarAnand

This comment has been minimized.

Show comment
Hide comment
@ChillarAnand

ChillarAnand Sep 6, 2015

Member

Closing as this is fixed. Thank you!

Member

ChillarAnand commented Sep 6, 2015

Closing as this is fixed. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment