New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving class structure of sync_data & adding unit tests #430

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@raun
Contributor

raun commented Apr 23, 2016

Improving the structure of Command class in sync_data.py so that it can be tested. Adding unit test for the same. Limiting the scope of atomic lock to writing to database. Check if the QR directory is present, if not create it.

try:
command_case(single_event, none_order)
except TypeError:
pass

This comment has been minimized.

@theskumar

theskumar Apr 23, 2016

Member

Probably you wanted to use:

with pytest.raises(TypeError):
  command_case(none_events, none_order)

with pytest.raises(TypeError):
  command_case(single_event, none_order)
@theskumar

theskumar Apr 23, 2016

Member

Probably you wanted to use:

with pytest.raises(TypeError):
  command_case(none_events, none_order)

with pytest.raises(TypeError):
  command_case(single_event, none_order)

This comment has been minimized.

@raun

raun Apr 24, 2016

Contributor

Let me change it and resubmit the patch. Thanks for pointing that out.

@raun

raun Apr 24, 2016

Contributor

Let me change it and resubmit the patch. Thanks for pointing that out.

@theskumar

This comment has been minimized.

Show comment
Hide comment
@theskumar

theskumar Apr 23, 2016

Member

Hi @raun, this project usages PEP8 as code style guide, checked via flake8[1]. This is causing the tests to fail.

Please resolve the PEP8 issues/warnings, so we can merge this. If you like you can use https://pypi.python.org/pypi/autopep8 ease your task.

Thanks for the contribution.

[1] https://travis-ci.org/pythonindia/junction/jobs/125199986#L957

Member

theskumar commented Apr 23, 2016

Hi @raun, this project usages PEP8 as code style guide, checked via flake8[1]. This is causing the tests to fail.

Please resolve the PEP8 issues/warnings, so we can merge this. If you like you can use https://pypi.python.org/pypi/autopep8 ease your task.

Thanks for the contribution.

[1] https://travis-ci.org/pythonindia/junction/jobs/125199986#L957

@theskumar

This comment has been minimized.

Show comment
Hide comment
@theskumar

theskumar May 15, 2016

Member

Closed by #431

Member

theskumar commented May 15, 2016

Closed by #431

@theskumar theskumar closed this May 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment