Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results filename causing file system issues #336

Closed
cheshrkat opened this issue Mar 21, 2022 · 2 comments · Fixed by #345
Closed

Results filename causing file system issues #336

cheshrkat opened this issue Mar 21, 2022 · 2 comments · Fixed by #345
Labels

Comments

@cheshrkat
Copy link

cheshrkat commented Mar 21, 2022

The fil results filename format includes colons: 2022-03-15T11:07:13.361 ...which I only really noticed when a backup process freaked out about them.

fil-filename-issue

Not a massive problem as I can exclude these from backups, but a safer default would be to replace colons (and probably the dots for good measure), leading to something like 2022-03-15T11-07-13_361

(edit - originally said slashes but this was a sanitised copy, not the original error)

@itamarst
Copy link
Collaborator

itamarst commented Mar 21, 2022

Oh hm never thought about the impact that would have on WSL or anything else that interoperates with Windows, since colons are fine on Linux.

@itamarst itamarst added the NEXT label Mar 26, 2022
itamarst added a commit that referenced this issue Mar 27, 2022
@cheshrkat
Copy link
Author

Thanks for fixing this, and so quickly! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants