Skip to content

Workaround for slow flamegraph rendering #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
itamarst merged 2 commits into from
Jul 22, 2022
Merged

Workaround for slow flamegraph rendering #392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddb3635
Increase minimium width of shown column, to speed up rendering of thi…
pythonspeed Jul 22, 2022
4bbbc1d
News file.
pythonspeed Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/390.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Speed up rendering of flamegraphs in cases where there are many smaller allocations, by filtering out allocations smaller than 0.2% of total memory. Future releases may re-enable showing smaller allocations if a better fix can be found.
1 change: 1 addition & 0 deletions memapi/src/flamegraph.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ pub fn get_flamegraph<I: IntoIterator<Item = String>>(
options.reverse_stack_order = reversed;
options.color_diffusion = true;
options.direction = flamegraph::Direction::Inverted;
options.min_width = 0.2;
// Maybe disable this some day; but for now it makes debugging much
// easier:
options.pretty_xml = true;
Expand Down