Skip to content

unwrap() is bad #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 19, 2022
Merged

unwrap() is bad #436

merged 5 commits into from
Oct 19, 2022

Conversation

@itamarst
Copy link
Collaborator

@itamarst itamarst commented Oct 15, 2022

Fixes #433

@github-actions
Copy link

github-actions bot commented Oct 15, 2022

Benchmark results

diff --git a/benchmarks/results/lots-of-peaks.json b/benchmarks/results/lots-of-peaks.json
index 383499f..5a6dae8 100644
--- a/benchmarks/results/lots-of-peaks.json
+++ b/benchmarks/results/lots-of-peaks.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-"3771157 (188.06264867688517%)",-]{+"5166677 (220.5153396671404%)",+}
    "D1mw": [-"2763734 (1002.7001956474165%)",-]{+"3924124 (1382.1588206079932%)",+}
    "DLmr": [-"1492746 (2257.3344509639564%)",-]{+"2001627 (3377.70190607192%)",+}
    "DLmw": [-"1858942 (1333.7673887649994%)",-]{+"2949348 (2059.1138862134244%)",+}
    "Dr": [-"231060633 (375.8621692938787%)",-]{+"218418480 (365.0015108903858%)",+}
    "Dw": [-"88001037 (338.04076205255154%)",-]{+"93196001 (360.13126641800176%)",+}
    "I1mr": [-"3555117 (1291.257363437142%)",-]{+"6030811 (2101.6964004182087%)",+}
    "ILmr": [-"14685 (224.7663551401869%)",-]{+"16882 (243.34720217372845%)",+}
    "Ir": [-"872039764 (403.39198904097907%)",-]{+"836528747 (394.2211096704718%)",+}
    "Overall": [-"1332452656 (406.55387644593173%)"-]{+"1357665386 (416.5846124902751%)"+}
}
diff --git a/benchmarks/results/multithreading-1.json b/benchmarks/results/multithreading-1.json
index 2d9d2d5..6949307 100644
--- a/benchmarks/results/multithreading-1.json
+++ b/benchmarks/results/multithreading-1.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-"1866984 (413.64545831772375%)",-]{+"2084687 (448.36694144718484%)",+}
    "D1mw": [-"393456 (455.7661355950594%)",-]{+"348960 (416.887787070586%)",+}
    "DLmr": [-"59324 (493.26483261518064%)",-]{+"79920 (624.822695035461%)",+}
    "DLmw": [-"77459 (220.9427598913281%)",-]{+"97898 (253.15227934044617%)",+}
    "Dr": [-"77161209 (571.2328286082947%)",-]{+"63445948 (500.15989758279784%)",+}
    "Dw": [-"30820902 (440.2169730406361%)",-]{+"27794186 (424.3091877809274%)",+}
    "I1mr": [-"1638950 (586.5692113122628%)",-]{+"1572968 (562.9208456938362%)",+}
    "ILmr": [-"7958 (171.83607149304927%)",-]{+"8913 (179.79409131602506%)",+}
    "Ir": [-"254542209 (491.30873094686683%)",-]{+"226430243 (456.9535382660309%)",+}
    "Overall": [-"382464110 (492.83707107089475%)"-]{+"339298767 (458.051964197586%)"+}
}
diff --git a/benchmarks/results/pystone.json b/benchmarks/results/pystone.json
index 3970408..b2fd469 100644
--- a/benchmarks/results/pystone.json
+++ b/benchmarks/results/pystone.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-"4542966 (144.07376585255872%)",-]{+"10423615 (208.68671898085964%)",+}
    "D1mw": [-"1628141 (267.75567903740483%)",-]{+"1135830 (170.58128284524912%)",+}
    "DLmr": [-"32802 (331.7507418397626%)",-]{+"41907 (393.1584470094439%)",+}
    "DLmw": [-"65725 (241.46577701248387%)",-]{+"74660 (260.9467965853238%)",+}
    "Dr": [-"367659717 (157.6310977517437%)",-]{+"306430037 (148.20533955677098%)",+}
    "Dw": [-"143586175 (159.9837295595579%)",-]{+"131025220 (155.16709792226595%)",+}
    "I1mr": [-"8784651 (214.74165578852526%)",-]{+"9327360 (224.16347306720397%)",+}
    "ILmr": [-"7924 (170.99086185271457%)",-]{+"8707 (177.39555555555555%)",+}
    "Ir": [-"1160233461 (157.01681262908485%)",-]{+"1054324173 (151.93377350946537%)",+}
    "Overall": [-"1734495915 (158.00764418609307%)"-]{+"1579084870 (152.9837290790935%)"+}
}
diff --git a/benchmarks/results/version.txt b/benchmarks/results/version.txt
index d8f4897..814fe99 100644
--- a/benchmarks/results/version.txt
+++ b/benchmarks/results/version.txt
@@ -1 +1 @@
[-2021.9.2.dev9+gc3af8e6.d20211105-]{+2022.9.4.dev4+g833638f.d20221015+}

@github-actions
Copy link

github-actions bot commented Oct 15, 2022

Benchmark results

diff --git a/benchmarks/results/lots-of-peaks.json b/benchmarks/results/lots-of-peaks.json
index 383499f..5861b7c 100644
--- a/benchmarks/results/lots-of-peaks.json
+++ b/benchmarks/results/lots-of-peaks.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-"3771157 (188.06264867688517%)",-]{+"5122946 (219.55287732714007%)",+}
    "D1mw": [-"2763734 (1002.7001956474165%)",-]{+"3916938 (1376.5616699529062%)",+}
    "DLmr": [-"1492746 (2257.3344509639564%)",-]{+"2001431 (3348.6543955330476%)",+}
    "DLmw": [-"1858942 (1333.7673887649994%)",-]{+"2949454 (2058.247740958856%)",+}
    "Dr": [-"231060633 (375.8621692938787%)",-]{+"218488051 (365.08872738015833%)",+}
    "Dw": [-"88001037 (338.04076205255154%)",-]{+"93243486 (360.2530567705578%)",+}
    "I1mr": [-"3555117 (1291.257363437142%)",-]{+"6034490 (2103.143558029683%)",+}
    "ILmr": [-"14685 (224.7663551401869%)",-]{+"16827 (242.86805909322464%)",+}
    "Ir": [-"872039764 (403.39198904097907%)",-]{+"836753240 (394.30307874578335%)",+}
    "Overall": [-"1332452656 (406.55387644593173%)"-]{+"1357813633 (416.6112018129025%)"+}
}
diff --git a/benchmarks/results/multithreading-1.json b/benchmarks/results/multithreading-1.json
index 2d9d2d5..5ee0b82 100644
--- a/benchmarks/results/multithreading-1.json
+++ b/benchmarks/results/multithreading-1.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-"1866984 (413.64545831772375%)",-]{+"2083999 (447.6373493473456%)",+}
    "D1mw": [-"393456 (455.7661355950594%)",-]{+"347984 (415.22288550904494%)",+}
    "DLmr": [-"59324 (493.26483261518064%)",-]{+"79839 (624.2219304005253%)",+}
    "DLmw": [-"77459 (220.9427598913281%)",-]{+"97907 (253.18792733872607%)",+}
    "Dr": [-"77161209 (571.2328286082947%)",-]{+"63443822 (500.1853331827893%)",+}
    "Dw": [-"30820902 (440.2169730406361%)",-]{+"27797123 (424.43658324048585%)",+}
    "I1mr": [-"1638950 (586.5692113122628%)",-]{+"1572881 (562.8802570901375%)",+}
    "ILmr": [-"7958 (171.83607149304927%)",-]{+"8896 (179.64189794091317%)",+}
    "Ir": [-"254542209 (491.30873094686683%)",-]{+"226407319 (456.93764557666395%)",+}
    "Overall": [-"382464110 (492.83707107089475%)"-]{+"339266980 (458.02765036055195%)"+}
}
diff --git a/benchmarks/results/pystone.json b/benchmarks/results/pystone.json
index 3970408..b951973 100644
--- a/benchmarks/results/pystone.json
+++ b/benchmarks/results/pystone.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-"4542966 (144.07376585255872%)",-]{+"11748572 (240.0678678519001%)",+}
    "D1mw": [-"1628141 (267.75567903740483%)",-]{+"1619079 (284.34635384347376%)",+}
    "DLmr": [-"32802 (331.7507418397626%)",-]{+"41895 (393.1975645601512%)",+}
    "DLmw": [-"65725 (241.46577701248387%)",-]{+"74653 (260.9490546105254%)",+}
    "Dr": [-"367659717 (157.6310977517437%)",-]{+"306423523 (148.20405479691894%)",+}
    "Dw": [-"143586175 (159.9837295595579%)",-]{+"131020035 (155.16403686373042%)",+}
    "I1mr": [-"8784651 (214.74165578852526%)",-]{+"9265272 (223.3376135265109%)",+}
    "ILmr": [-"7924 (170.99086185271457%)",-]{+"8697 (177.28605705145296%)",+}
    "Ir": [-"1160233461 (157.01681262908485%)",-]{+"1053891269 (151.91215599754673%)",+}
    "Overall": [-"1734495915 (158.00764418609307%)"-]{+"1585623869 (153.34124457260208%)"+}
}
diff --git a/benchmarks/results/version.txt b/benchmarks/results/version.txt
index d8f4897..bb1a6a6 100644
--- a/benchmarks/results/version.txt
+++ b/benchmarks/results/version.txt
@@ -1 +1 @@
[-2021.9.2.dev9+gc3af8e6.d20211105-]{+2022.9.4.dev5+g980c045.d20221015+}

@pythonspeed
Too much memory isn't a problem; so long as we did OOM detection and …
0effe60 
…didn't too

it soon, that's what we care about.
@github-actions
Copy link

github-actions bot commented Oct 19, 2022

Benchmark results

diff --git a/benchmarks/results/lots-of-peaks.json b/benchmarks/results/lots-of-peaks.json
index 383499f..1a7e837 100644
--- a/benchmarks/results/lots-of-peaks.json
+++ b/benchmarks/results/lots-of-peaks.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-"3771157 (188.06264867688517%)",-]{+"5166739 (220.54743479038922%)",+}
    "D1mw": [-"2763734 (1002.7001956474165%)",-]{+"3922374 (1381.1349472831555%)",+}
    "DLmr": [-"1492746 (2257.3344509639564%)",-]{+"2001585 (3357.4699736353873%)",+}
    "DLmw": [-"1858942 (1333.7673887649994%)",-]{+"2949301 (2058.4062099510616%)",+}
    "Dr": [-"231060633 (375.8621692938787%)",-]{+"218463363 (365.0570339455839%)",+}
    "Dw": [-"88001037 (338.04076205255154%)",-]{+"93215117 (360.1726194249158%)",+}
    "I1mr": [-"3555117 (1291.257363437142%)",-]{+"6034122 (2102.968210078371%)",+}
    "ILmr": [-"14685 (224.7663551401869%)",-]{+"16809 (242.60626113514888%)",+}
    "Ir": [-"872039764 (403.39198904097907%)",-]{+"836772163 (394.3141482815472%)",+}
    "Overall": [-"1332452656 (406.55387644593173%)"-]{+"1357974433 (416.6542285435369%)"+}
}
diff --git a/benchmarks/results/multithreading-1.json b/benchmarks/results/multithreading-1.json
index 2d9d2d5..6b982c2 100644
--- a/benchmarks/results/multithreading-1.json
+++ b/benchmarks/results/multithreading-1.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-"1866984 (413.64545831772375%)",-]{+"2098837 (450.7795800011699%)",+}
    "D1mw": [-"393456 (455.7661355950594%)",-]{+"349111 (417.86777627038396%)",+}
    "DLmr": [-"59324 (493.26483261518064%)",-]{+"79792 (623.3978353558543%)",+}
    "DLmw": [-"77459 (220.9427598913281%)",-]{+"97963 (253.30433013567864%)",+}
    "Dr": [-"77161209 (571.2328286082947%)",-]{+"63447641 (500.1859719793808%)",+}
    "Dw": [-"30820902 (440.2169730406361%)",-]{+"27794012 (424.31987255917136%)",+}
    "I1mr": [-"1638950 (586.5692113122628%)",-]{+"1572900 (562.8654161933741%)",+}
    "ILmr": [-"7958 (171.83607149304927%)",-]{+"8894 (179.5883668903803%)",+}
    "Ir": [-"254542209 (491.30873094686683%)",-]{+"226455350 (457.0200995439016%)",+}
    "Overall": [-"382464110 (492.83707107089475%)"-]{+"339379865 (458.16438726115%)"+}
}
diff --git a/benchmarks/results/pystone.json b/benchmarks/results/pystone.json
index 3970408..e7fb216 100644
--- a/benchmarks/results/pystone.json
+++ b/benchmarks/results/pystone.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-"4542966 (144.07376585255872%)",-]{+"10563627 (218.35211602771%)",+}
    "D1mw": [-"1628141 (267.75567903740483%)",-]{+"1878300 (301.2109292146314%)",+}
    "DLmr": [-"32802 (331.7507418397626%)",-]{+"41984 (393.71764376661537%)",+}
    "DLmw": [-"65725 (241.46577701248387%)",-]{+"74645 (261.00817497465545%)",+}
    "Dr": [-"367659717 (157.6310977517437%)",-]{+"306428288 (148.2050310504792%)",+}
    "Dw": [-"143586175 (159.9837295595579%)",-]{+"131024963 (155.16700341880994%)",+}
    "I1mr": [-"8784651 (214.74165578852526%)",-]{+"9264953 (223.33275959680833%)",+}
    "ILmr": [-"7924 (170.99086185271457%)",-]{+"8691 (177.23960184856026%)",+}
    "Ir": [-"1160233461 (157.01681262908485%)",-]{+"1053909037 (151.91339158281832%)",+}
    "Overall": [-"1734495915 (158.00764418609307%)"-]{+"1581949408 (153.1755806092708%)"+}
}
diff --git a/benchmarks/results/version.txt b/benchmarks/results/version.txt
index d8f4897..b1e2bd8 100644
--- a/benchmarks/results/version.txt
+++ b/benchmarks/results/version.txt
@@ -1 +1 @@
[-2021.9.2.dev9+gc3af8e6.d20211105-]{+2022.9.4.dev6+g19d4c85.d20221019+}

@itamarst itamarst merged commit 4b59ac1 into master Oct 19, 2022
@itamarst itamarst deleted the 433-unwrap-is-bad branch October 19, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fil crashes with panic if /proc/meminfo is missing information

3 participants

@itamarst @pythonspeed