QuantizeAvx2: Manually hoist zero_point loads#1124
Closed
swolchok wants to merge 1 commit into
Closed
Conversation
Summary: When T is unsigned char, the compiler can't prove that the storages in this loop don't alias qparams, so it loads zero_point on each iteration. We manually hoist the loads to get around this. Differential Revision: D36415089 fbshipit-source-id: 7a8d3e8a5ce7e5d39b207e605e3042be83904de8
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D36415089 |
pytorch-bot Bot
pushed a commit
that referenced
this pull request
Feb 26, 2026
Summary: Pull Request resolved: #1124 When T is unsigned char, the compiler can't prove that the storages in this loop don't alias qparams, so it loads zero_point on each iteration. We manually hoist the loads to get around this. Reviewed By: jianyuh Differential Revision: D36415089 fbshipit-source-id: 74bedd92b0ea9139a29170966e93fd7cce5e8c99
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: When T is unsigned char, the compiler can't prove that the storages in this loop don't alias qparams, so it loads zero_point on each iteration. We manually hoist the loads to get around this.
Differential Revision: D36415089