Print the code when the check failed #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/254
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 66361ce with merge base 3ed1605 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
HDCharles
approved these changes
May 17, 2024
Contributor
HDCharles
left a comment
HDCharles
left a comment
There was a problem hiding this comment.
yeah hopefully we can figure out why this suddenly became flaky, it certainly shouldn't be
Summary: python test/integration/test_integration.py -k test_weight_only_quant_force_mixed_mm Test Plan: Reviewers: Subscribers: Tasks: Tags:
Contributor
Author
|
@HDCharles is this fixed now? looks like we don't see the error anymore |
yanbing-j
pushed a commit
to yanbing-j/ao
that referenced
this pull request
Dec 9, 2024
… CLI (pytorch#254) * Clean up logging for generate subcommand and setup log levels * Clean up logging for generate subcommand and setup log levels Use the logging library to separate between the verbosity/criticality of logs that the user might be used. * Apply lintrunner * Update torchchat.py Co-authored-by: Dave Bort <dbort@users.noreply.github.com> --------- Co-authored-by: George Hong <georgehong@fb.com> Co-authored-by: Dave Bort <dbort@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
seems
test_weight_only_quant_force_mixed_mmis flaky, we want to see what code gets produced when it failedTest Plan:
python test/integration/test_integration.py -k test_weight_only_quant_force_mixed_mm
Reviewers:
Subscribers:
Tasks:
Tags: