Skip to content

Rename NVFP4Tensor's _per_tensor_scale and _act_per_tensor_scale fields #3168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 13, 2025
Merged

Rename NVFP4Tensor's _per_tensor_scale and _act_per_tensor_scale fields #3168

merged 7 commits into from
Oct 13, 2025

Conversation

@vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Oct 13, 2025 •
edited
Loading

Summary:

_per_tensor_scale -> per_tensor_scale
_act_per_tensor_scale -> act_per_tensor_scale

(AI assisted)

Test Plan:

pytest test/prototype/mx_formats/ -s -x

Reviewers:

Subscribers:

Tasks:

Tags:

vkuzo added 4 commits October 13, 2025 09:45
@vkuzo
Update
21cc7e5 
[ghstack-poisoned]
@vkuzo
Update
8d13840 
[ghstack-poisoned]
@vkuzo
Update
31defd5 
[ghstack-poisoned]
@vkuzo
Update
c49def8 
[ghstack-poisoned]
@vkuzo
Copy link
Contributor Author

vkuzo commented Oct 13, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 13, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3168

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vkuzo added a commit that referenced this pull request Oct 13, 2025
@vkuzo
Rename NVFP4Tensor's _per_tensor_scale and _act_per_tensor_scale fields
35878fa 
Summary:

_per_tensor_scale -> per_tensor_scale
_act_per_tensor_scale -> act_per_tensor_scale

Test Plan:

```bash
pytest test/prototype/mx_formats/ -s -x
```

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: 97873f0
ghstack-comment-id: 3398467846
Pull-Request: #3168
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 13, 2025
This was referenced Oct 13, 2025
Merged
Merged
@vkuzo vkuzo added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Oct 13, 2025
@vkuzo vkuzo requested a review from jerryzh168 October 13, 2025 17:39
@vkuzo vkuzo mentioned this pull request Oct 13, 2025
Merged
@jerryzh168
Copy link
Contributor

just curious, why not scale and act_scale to allow for other granularity as well?

vkuzo added 3 commits October 13, 2025 14:07
@vkuzo
Update
eaf92b9 
[ghstack-poisoned]
@vkuzo
Update
1296a90 
[ghstack-poisoned]
@vkuzo
Update
059532c 
[ghstack-poisoned]
@vkuzo vkuzo changed the base branch from gh/vkuzo/142/head to main October 13, 2025 21:08
@vkuzo vkuzo merged commit ba4593f into main Oct 13, 2025
17 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerryzh168 jerryzh168 jerryzh168 approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vkuzo @jerryzh168