Skip to content

move float8 blockwise kernels out of prototype #3256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 30, 2025
+7 −5
Merged

move float8 blockwise kernels out of prototype #3256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
990ef89
Update
vkuzo Oct 29, 2025
cce08f0
Update
vkuzo Oct 29, 2025
f76e10b
Update
vkuzo Oct 29, 2025
57b8876
Update
vkuzo Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/1xL4_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,4 @@ jobs:
pytest test/dtypes/test_affine_quantized_float.py --verbose -s
./test/float8/test_everything_single_gpu.sh
python test/quantization/quantize_/workflows/float8/test_float8_tensor.py
python test/kernel/test_blockwise_triton.py --verbose -s
2 changes: 1 addition & 1 deletion benchmarks/benchmark_blockwise_scaled_linear_triton.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from triton.testing import do_bench

from torchao.float8.float8_utils import compute_error
from torchao.prototype.blockwise_fp8_inference.blockwise_quantization import (
from torchao.kernel.blockwise_quantization import (
blockwise_fp8_gemm,
fp8_blockwise_act_quant,
fp8_blockwise_weight_quant,
Expand Down
2 changes: 1 addition & 1 deletion test/prototype/test_blockwise_triton.py → test/kernel/test_blockwise_triton.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

triton = pytest.importorskip("triton", reason="Triton required to run this test")

from torchao.prototype.blockwise_fp8_inference.blockwise_quantization import (
from torchao.kernel.blockwise_quantization import (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note for later: let's rename this torchao.kernels* (plural)

blockwise_fp8_gemm,
fp8_blockwise_act_quant,
fp8_blockwise_weight_dequant,
Expand Down
0 ...e_fp8_inference/blockwise_quantization.py → torchao/kernel/blockwise_quantization.py
View file
Open in desktop
File renamed without changes.
5 changes: 3 additions & 2 deletions torchao/prototype/blockwise_fp8_inference/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
from .blockwise_linear import BlockwiseQuantLinear
from .blockwise_quantization import (
from torchao.kernel.blockwise_quantization import (
blockwise_fp8_gemm,
fp8_blockwise_act_quant,
fp8_blockwise_weight_dequant,
fp8_blockwise_weight_quant,
)

from .blockwise_linear import BlockwiseQuantLinear

__all__ = [
"blockwise_fp8_gemm",
"BlockwiseQuantLinear",
Expand Down
2 changes: 1 addition & 1 deletion torchao/prototype/blockwise_fp8_inference/blockwise_linear.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import torch
from torch import nn

from torchao.prototype.blockwise_fp8_inference.blockwise_quantization import (
from torchao.kernel.blockwise_quantization import (
blockwise_fp8_gemm,
fp8_blockwise_act_quant,
)
Expand Down
Loading