make torchao test discovery pass in fbcode #351
Conversation
Summary: Running `buck test @//mode/dev-nosan fbcode//pytorch/ao/test:torchao_tests` used to work but stopped working sometime in the past ~months due to test discovery being broken. This diff fixes test discovery and adds a blocklist to all of the broken tests, so we can at least run the passing tests easily. Note that for now we have some tests using `pytest` which is handled in a custom way. In a future PR it would be great to make torchao use a single testing framework. Reviewed By: jerryzh168 Differential Revision: D58422127
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/351
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 954be83 with merge base eae864c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58422127 |
msaroufim
left a comment
msaroufim
left a comment
There was a problem hiding this comment.
ok! Kinda concerning how many tests are broken internally though
this PR enables the tests to at least be discovered and tracked in fbcode, future work can fix individual tests in separate PRs |
|
Oh yes was not implying you fix the failures right now, @vkuzo please feel free to merge this whenever you're ready |
3 participants
Summary:
Running
buck test @//mode/dev-nosan fbcode//pytorch/ao/test:torchao_testsusedto work but stopped working sometime in the past ~months due to test
discovery being broken. This diff fixes test discovery and adds a blocklist
to all of the broken tests, so we can at least run the passing tests easily.
Note that for now we have some tests using
pytestwhich is handled in a customway. In a future PR it would be great to make torchao use a single testing
framework.
Reviewed By: jerryzh168
Differential Revision: D58422127