Skip to content

Conversation

@msaroufim
Copy link
Member

@msaroufim msaroufim commented Jun 17, 2024

When we merged #369 we completely got rid of any requirements.txt we had because we have no dependencies outside of torch. The torch dependency is also pulled defined directly inside a setup.py because it's an environment variable that will decide which version of pytorch we'll install.

This passed CI just fine but then when the script was merged to main and the binary builds were triggered it broke all our binary builds

This is because in our binary build scripts in packaging/ we still run pip install -r requirements.txt and we also need to install pip install -r dev-requirements.txt because later in our post build validation we check we run pytest. Since the requirements.txt no longer exists the script fails.

The reason why we didn't catch this in CI is because we don't run binary validation scripts per commit but we run it when code gets merged to main

In the future before making CI changes it's worth triggering a manual workflow-dispatch to make sure this change is safe to land

Doing a manual dispatch to make sure this passes before merging as I've done here https://github.com/pytorch/ao/actions/workflows/build_wheels_linux.yml

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/390

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (2 Unrelated Failures)

As of commit 5b3a639 with merge base 1b78dda (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 17, 2024
@msaroufim msaroufim requested review from atalman and huydhn June 17, 2024 20:44
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add a bit more explanation, but sure, if it fixes the builds..

@msaroufim
Copy link
Member Author

All builds jobs passed except 1 which was a flake so this is good to merge

Screenshot 2024-06-17 at 2 29 57 PM

@msaroufim msaroufim merged commit d043d23 into main Jun 17, 2024
@msaroufim msaroufim deleted the msaroufim-patch-10 branch June 17, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants