Fix a bug in pytorch_struct that raises NotImplemented error in the latest pytorch-nightly 20210107#184
Merged
Merged
Conversation
wconstab
approved these changes
Jan 8, 2021
wconstab
left a comment
wconstab
left a comment
Contributor
There was a problem hiding this comment.
Did you also make this change on the master branch? might be best practice is to merge first to master then cherry pick to 0.1, but either way as long as it gets on both branches its ok
Contributor
Author
This time I will submit separate PRs. Next time I will submit to master first then cherry-pick to 0.1. Or maybe it's better to first test it on 0.1 using gh actions then cherry-pick to master? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.