Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update CI workflow versions to use latest checkout (removes deprecation warning) #1734

Closed

Conversation

bryantbiggs
Copy link
Contributor

@bryantbiggs bryantbiggs commented Mar 13, 2024

  • actions/checkout v3 uses deprecated nodejs runtime, no-op bump to v4 to remove warning
  • Use python 3.9 as minimum version in CI workflows given 3.8 is coming to EOL
  • Use Ubuntu 22.04 as minimum version in CI workflows given 18.04 is EOL
  • Use Windows 2022 versions in CI workflows given 2019 is coming to EOL

…precation warning), and ensure CUDA 12.4 is added consistently across builds
@@ -30,10 +30,10 @@ jobs:
runs-on: linux.2xlarge
strategy:
matrix:
cuda_version: ["124", "121", "118"]
cuda_version: ["118", "121", "124"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the benefit of changing the order?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None! it was just trying to be consistent with increasing versions left-to-right

strategy:
matrix:
cuda_version: ["121", "118"]
cuda_version: ["118", "121", "124"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #1725

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! reverted this change in e5c34ca

@@ -37,15 +37,15 @@ jobs:
runs-on: linux.12xlarge.ephemeral
strategy:
matrix:
cuda_version: ["12.1", "11.8"]
cuda_version: ["11.8", "12.1", "12.4"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #1726

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! reverted this change in e5c34ca

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily needed, but I appreciate it.

OS_BASE: "ubuntu18.04"
CUDA_VERSION: "11.8.0"
OS: "ubuntu2204"
OS_BASE: "ubuntu22.04"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

@bryantbiggs bryantbiggs changed the title chore: Update CI workflow versions to use latest checkout (removes deprecation warning), and ensure CUDA 12.4 is added consistently across builds chore: Update CI workflow versions to use latest checkout (removes deprecation warning) Mar 13, 2024
@bryantbiggs
Copy link
Contributor Author

hmmm actions/runner#2906

@atalman
Copy link
Contributor

atalman commented May 6, 2024

@bryantbiggs this PR looks Ok, however there are some errors we want to resolve:

/home/ec2-user/actions-runner/externals/node20/bin/node: /lib64/libm.so.6: version `GLIBC_2.27' not found (required by /home/ec2-user/actions-runner/externals/node20/bin/node)

https://github.com/pytorch/builder/actions/runs/8970189807/job/24636329217?pr=1734

I see these are related to your comment about: actions/runner#2906

@bryantbiggs
Copy link
Contributor Author

@atalman correct - I opened this #1762 that I believe would need to be resolved first, but I think only internal Meta employees would be able to handle that

@bryantbiggs bryantbiggs closed this Sep 9, 2024
@bryantbiggs bryantbiggs deleted the chore/update-ci-workflow-versions branch September 9, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants