Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanding the contribution guide, especially including instructions to add a new DataPipe #354

Closed
wants to merge 2 commits into from

Conversation

NivekT
Copy link
Contributor

@NivekT NivekT commented Apr 8, 2022

Stack from ghstack:

Expanding the contribution guide, especially including instructions to add a new DataPipe

Differential Revision: D35509619

[ghstack-poisoned]
NivekT added a commit that referenced this pull request Apr 8, 2022
ghstack-source-id: e308c5852aad44f4d770ea5a20a5ff0aab03f093
Pull Request resolved: #354
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 8, 2022
@NivekT NivekT changed the title Updating contribution guide Expanding the contribution guide, especially including instructions to add a new DataPipe Apr 8, 2022
@NivekT
Copy link
Contributor Author

NivekT commented Apr 8, 2022

@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the effort!

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
…tructions to add a new DataPipe"


Expanding the contribution guide, especially including instructions to add a new DataPipe

Differential Revision: [D35509619](https://our.internmc.facebook.com/intern/diff/D35509619)

[ghstack-poisoned]
NivekT added a commit that referenced this pull request Apr 8, 2022
ghstack-source-id: 13b7fb1da1a6092a07eb27bad025912aacf20c38
Pull Request resolved: #354
@NivekT
Copy link
Contributor Author

NivekT commented Apr 8, 2022

@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot deleted the gh/NivekT/71/head branch April 15, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants