From 1bd292373a1ba1c6069445a01ba71a5e3baacda9 Mon Sep 17 00:00:00 2001 From: zhenyanzhang Date: Wed, 9 Apr 2025 21:23:32 -0700 Subject: [PATCH] [ez] Remove duplicate log_intermediate_output_delegate_helper - Remove duplicate `log_intermediate_output_delegate_helper()` - Return directly rather than getting the value first. Differential Revision: [D72768360](https://our.internmc.facebook.com/intern/diff/D72768360/) [ghstack-poisoned] --- devtools/etdump/etdump_flatcc.cpp | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/devtools/etdump/etdump_flatcc.cpp b/devtools/etdump/etdump_flatcc.cpp index f6e18bf49d2..4e300ee4065 100644 --- a/devtools/etdump/etdump_flatcc.cpp +++ b/devtools/etdump/etdump_flatcc.cpp @@ -323,40 +323,32 @@ Result ETDumpGen::log_intermediate_output_delegate( const char* name, DelegateDebugIntId delegate_debug_index, const ArrayRef output) { - log_intermediate_output_delegate_helper(name, delegate_debug_index, output); - Result result = log_intermediate_output_delegate_helper( + return log_intermediate_output_delegate_helper( name, delegate_debug_index, output); - return result; } Result ETDumpGen::log_intermediate_output_delegate( const char* name, DelegateDebugIntId delegate_debug_index, const int& output) { - log_intermediate_output_delegate_helper(name, delegate_debug_index, output); - Result result = log_intermediate_output_delegate_helper( + return log_intermediate_output_delegate_helper( name, delegate_debug_index, output); - return result; } Result ETDumpGen::log_intermediate_output_delegate( const char* name, DelegateDebugIntId delegate_debug_index, const bool& output) { - log_intermediate_output_delegate_helper(name, delegate_debug_index, output); - Result result = log_intermediate_output_delegate_helper( + return log_intermediate_output_delegate_helper( name, delegate_debug_index, output); - return result; } Result ETDumpGen::log_intermediate_output_delegate( const char* name, DelegateDebugIntId delegate_debug_index, const double& output) { - log_intermediate_output_delegate_helper(name, delegate_debug_index, output); - Result result = log_intermediate_output_delegate_helper( + return log_intermediate_output_delegate_helper( name, delegate_debug_index, output); - return result; } template