From 918d22eea7fce98eca0821d63cfcc45b2b20a0ba Mon Sep 17 00:00:00 2001 From: Jack Zhang <32371937+jackzhxng@users.noreply.github.com> Date: Mon, 12 May 2025 14:11:19 -0700 Subject: [PATCH] Rename "topic: not user facing" ghstack-source-id: 1d28ddf98a4eb42cc1a996ad51067b504416818d Pull Request resolved: https://github.com/pytorch/executorch/pull/10791 --- .github/scripts/label_utils.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/scripts/label_utils.py b/.github/scripts/label_utils.py index 81668dad0cb..5a9c15bf3c1 100644 --- a/.github/scripts/label_utils.py +++ b/.github/scripts/label_utils.py @@ -22,12 +22,12 @@ LABEL_ERR_MSG_TITLE = "This PR needs a `release notes:` label" LABEL_ERR_MSG = f"""# {LABEL_ERR_MSG_TITLE} -If your changes are user facing and intended to be a part of release notes, please use a label starting with `release notes:`. +If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with `release notes:`. -If not, please add the `topic: not user facing` label. +If not, please add the `release notes: none` label. To add a label, you can comment to pytorchbot, for example -`@pytorchbot label "topic: not user facing"` +`@pytorchbot label "release notes: none"` For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work. @@ -115,7 +115,7 @@ def has_required_labels(pr: "GitHubPR") -> bool: pr_labels = pr.get_labels() # Check if PR is not user facing is_not_user_facing_pr = any( - label.strip() == "topic: not user facing" for label in pr_labels + label.strip() == "release notes: none" for label in pr_labels ) return is_not_user_facing_pr or any( label.strip() in get_release_notes_labels(pr.org, pr.project)