From d3a3bffaf63487f5f3ce27b84ffe04dea377212e Mon Sep 17 00:00:00 2001 From: Mengwei Liu Date: Fri, 27 Jun 2025 11:43:43 -0700 Subject: [PATCH] Fix jni_layer_llama.cpp generate_from_pos missing return Summary: Fix the issue on #11952 where we are missing a return in generate_from_pos() Reviewed By: GregoryComer Differential Revision: D77456146 --- extension/android/jni/jni_layer_llama.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/extension/android/jni/jni_layer_llama.cpp b/extension/android/jni/jni_layer_llama.cpp index 12a04ea7a13..257f7282c65 100644 --- a/extension/android/jni/jni_layer_llama.cpp +++ b/extension/android/jni/jni_layer_llama.cpp @@ -311,12 +311,12 @@ class ExecuTorchLlmJni : public facebook::jni::HybridClass { .seq_len = seq_len, .temperature = temperature_, }; - runner_->generate_from_pos( + return static_cast(runner_->generate_from_pos( prompt->toStdString(), start_pos, config, [callback](std::string result) { callback->onResult(result); }, - [callback](const llm::Stats& stats) { callback->onStats(stats); }); + [callback](const llm::Stats& stats) { callback->onStats(stats); })); } }