From fa9ebc98a068824968889d2100cc5add40d1b30d Mon Sep 17 00:00:00 2001 From: Martin Pavella Date: Thu, 28 Aug 2025 15:29:52 +0200 Subject: [PATCH] NXP backend: Fix incorrect `linear` test. --- .../node_converter/test_linear_converter.py | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/backends/nxp/tests/ir/converter/node_converter/test_linear_converter.py b/backends/nxp/tests/ir/converter/node_converter/test_linear_converter.py index 4a19c3d8c4b..858724522cd 100644 --- a/backends/nxp/tests/ir/converter/node_converter/test_linear_converter.py +++ b/backends/nxp/tests/ir/converter/node_converter/test_linear_converter.py @@ -10,6 +10,7 @@ from executorch.backends.nxp.tests.executorch_pipeline import to_edge_program from executorch.backends.nxp.tests.executors import convert_run_compare from executorch.backends.nxp.tests.models import LinearModule +from executorch.exir.dialects._ops import ops as exir_ops @pytest.fixture(autouse=True) @@ -26,15 +27,23 @@ def test_linear_conversion__with_bias(): input_data = np.random.random(input_shape).astype(np.float32) - convert_run_compare(edge_program, input_data=input_data, atol=1.0e-6) + nodes = list(edge_program.graph.nodes) + assert nodes[4].target == exir_ops.edge.aten.addmm.default + assert len(nodes[4].args) == 3 # Has bias. + + convert_run_compare(edge_program, input_data=input_data) def test_linear_conversion__without_bias(): input_shape = (10, 32) edge_program = to_edge_program( - LinearModule(bias=True), input_shape + LinearModule(bias=False), input_shape ).exported_program() input_data = np.random.random(input_shape).astype(np.float32) - convert_run_compare(edge_program, input_data=input_data, atol=1.0e-6) + nodes = list(edge_program.graph.nodes) + assert nodes[3].target == exir_ops.edge.aten.mm.default + assert len(nodes[3].args) == 2 # No bias. + + convert_run_compare(edge_program, input_data=input_data)