Skip to content

Update cache position population and arg order for multimodal runner #14343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pytorchbot wants to merge 1 commit into from
Closed

Update cache position population and arg order for multimodal runner #14343

pytorchbot wants to merge 1 commit into from

Conversation

@pytorchbot
Copy link
Collaborator

@pytorchbot pytorchbot commented Sep 16, 2025

Summary

For voxtral and phi-3, we construct the cache_position_tensor like before; for llava, it will construct underneath so we pass in size 1.

Test plan

CI

@kirklandsign @pytorchbot
Update cache position population and arg order for multimodal runner (#…
bf7f343 
…14225)

For voxtral and phi-3, we construct the cache_position_tensor like
before; for llava, it will construct underneath so we pass in size 1.

(cherry picked from commit ea4f004)
This was referenced Sep 16, 2025
Closed
Merged
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 16, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14343

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Pending

As of commit bf7f343 with merge base 10e93fb (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 16, 2025
@mergennachin
Copy link
Contributor

mergennachin commented Sep 16, 2025

Part of release/1.0 due to recent fast forwarding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackzhxng jackzhxng jackzhxng approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@swolchok swolchok Awaiting requested review from swolchok

@mergennachin mergennachin Awaiting requested review from mergennachin mergennachin is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pytorchbot @mergennachin @jackzhxng @kirklandsign