From 23ac4ded8651781632de166be287cc7403c1c2a0 Mon Sep 17 00:00:00 2001 From: Hansong Zhang Date: Tue, 16 Sep 2025 11:42:03 -0700 Subject: [PATCH 1/3] Fix buck target for LLM runner util --- extension/llm/runner/targets.bzl | 28 ++++++++++++++++------------ extension/llm/runner/util.h | 3 +++ 2 files changed, 19 insertions(+), 12 deletions(-) diff --git a/extension/llm/runner/targets.bzl b/extension/llm/runner/targets.bzl index 8ae0c1ba3be..a5e406e2f17 100644 --- a/extension/llm/runner/targets.bzl +++ b/extension/llm/runner/targets.bzl @@ -11,17 +11,6 @@ def define_common_targets(): ], ) - runtime.cxx_library( - name = "stats", - exported_headers = [ - "stats.h", - "util.h", - ], - visibility = [ - "@EXECUTORCH_CLIENTS", - ], - ) - runtime.cxx_library( name = "constants", exported_headers = [ @@ -35,6 +24,21 @@ def define_common_targets(): for aten in get_aten_mode_options(): aten_suffix = "_aten" if aten else "" + runtime.cxx_library( + name = "stats", + exported_headers = [ + "stats.h", + "util.h", + ], + visibility = [ + "@EXECUTORCH_CLIENTS", + ], + exported_deps = [ + ":constants", + "//executorch/extension/module:module" + aten_suffix, + ], + ) + runtime.cxx_library( name = "text_decoder_runner" + aten_suffix, exported_headers = ["text_decoder_runner.h"], @@ -43,7 +47,7 @@ def define_common_targets(): "@EXECUTORCH_CLIENTS", ], exported_deps = [ - ":stats", + ":stats" + aten_suffix, "//executorch/kernels/portable/cpu/util:arange_util" + aten_suffix, "//executorch/extension/llm/sampler:sampler" + aten_suffix, "//executorch/extension/llm/runner/io_manager:io_manager" + aten_suffix, diff --git a/extension/llm/runner/util.h b/extension/llm/runner/util.h index 5ede889e034..513fd109255 100644 --- a/extension/llm/runner/util.h +++ b/extension/llm/runner/util.h @@ -7,11 +7,14 @@ */ #pragma once +#include +#include #include #include #include #include #include +#include #if defined(__linux__) || defined(__ANDROID__) || defined(__unix__) #include #endif From 3634467bae762d24937a06cbbc940e442851526b Mon Sep 17 00:00:00 2001 From: Hansong Zhang Date: Tue, 16 Sep 2025 13:52:35 -0700 Subject: [PATCH 2/3] Fix --- extension/llm/runner/targets.bzl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extension/llm/runner/targets.bzl b/extension/llm/runner/targets.bzl index a5e406e2f17..0c5ad4170e5 100644 --- a/extension/llm/runner/targets.bzl +++ b/extension/llm/runner/targets.bzl @@ -25,7 +25,7 @@ def define_common_targets(): aten_suffix = "_aten" if aten else "" runtime.cxx_library( - name = "stats", + name = "stats" + aten_suffix, exported_headers = [ "stats.h", "util.h", From e3970af4409632dfb442cd420d0befe2afe1c680 Mon Sep 17 00:00:00 2001 From: Hansong Zhang Date: Tue, 16 Sep 2025 15:24:51 -0700 Subject: [PATCH 3/3] Add tensor deps to buck --- extension/llm/runner/targets.bzl | 1 + 1 file changed, 1 insertion(+) diff --git a/extension/llm/runner/targets.bzl b/extension/llm/runner/targets.bzl index 0c5ad4170e5..242860a195a 100644 --- a/extension/llm/runner/targets.bzl +++ b/extension/llm/runner/targets.bzl @@ -36,6 +36,7 @@ def define_common_targets(): exported_deps = [ ":constants", "//executorch/extension/module:module" + aten_suffix, + "//executorch/extension/tensor:tensor" + aten_suffix, ], )