From 5e183b1b7c4ebdaa7f77fb1c240a0f9517b6b618 Mon Sep 17 00:00:00 2001 From: Chen Lai Date: Thu, 25 Sep 2025 11:33:28 -0700 Subject: [PATCH 1/8] set a dependency job --- .github/workflows/trunk.yml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/.github/workflows/trunk.yml b/.github/workflows/trunk.yml index 38247c257df..35d8aa7a769 100644 --- a/.github/workflows/trunk.yml +++ b/.github/workflows/trunk.yml @@ -973,7 +973,25 @@ jobs: # Test llama2 PYTHON_EXECUTABLE=python bash .ci/scripts/test_llama.sh -model stories110M -build_tool "${BUILD_TOOL}" -mode "${MODE}" -dtype "${DTYPE}" -pt2e_quantize "${PT2E_QUANTIZE}" + # this is for filtering out the qnn changes such that qnn jobs only triggered when the specific files are changed + changes: + runs-on: ubuntu-latest + outputs: + qnn: ${{ steps.filter.outputs.qnn }} + steps: + - uses: actions/checkout@v4 + - uses: dorny/paths-filter@v3 + id: filter + with: + filters: | + qnn: + - 'backends/qualcomm/**' + - 'examples/qualcomm/**' + - 'examples/models/llama/**' + test-static-llama-qnn-eval-linux: + needs: changes # has dependency on changes jobs defined above + if: needs.changes.outputs.qnn == 'true' name: test-static-llama-qnn-eval-linux uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main permissions: From dfff38745660e09b3473a3884a9b9bac8242a594 Mon Sep 17 00:00:00 2001 From: Chen Lai Date: Thu, 25 Sep 2025 11:46:41 -0700 Subject: [PATCH 2/8] debug --- .github/workflows/trunk.yml | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/.github/workflows/trunk.yml b/.github/workflows/trunk.yml index 35d8aa7a769..c6ec40cf6f7 100644 --- a/.github/workflows/trunk.yml +++ b/.github/workflows/trunk.yml @@ -973,24 +973,24 @@ jobs: # Test llama2 PYTHON_EXECUTABLE=python bash .ci/scripts/test_llama.sh -model stories110M -build_tool "${BUILD_TOOL}" -mode "${MODE}" -dtype "${DTYPE}" -pt2e_quantize "${PT2E_QUANTIZE}" - # this is for filtering out the qnn changes such that qnn jobs only triggered when the specific files are changed - changes: - runs-on: ubuntu-latest - outputs: - qnn: ${{ steps.filter.outputs.qnn }} - steps: - - uses: actions/checkout@v4 - - uses: dorny/paths-filter@v3 - id: filter - with: - filters: | - qnn: - - 'backends/qualcomm/**' - - 'examples/qualcomm/**' - - 'examples/models/llama/**' + # # this is for filtering out the qnn changes such that qnn jobs only triggered when the specific files are changed + # changes: + # runs-on: ubuntu-latest + # outputs: + # qnn: ${{ steps.filter.outputs.qnn }} + # steps: + # - uses: actions/checkout@v4 + # - uses: dorny/paths-filter@v3 + # id: filter + # with: + # filters: | + # qnn: + # - 'backends/qualcomm/**' + # - 'examples/qualcomm/**' + # - 'examples/models/llama/**' test-static-llama-qnn-eval-linux: - needs: changes # has dependency on changes jobs defined above + # needs: changes # has dependency on changes jobs defined above if: needs.changes.outputs.qnn == 'true' name: test-static-llama-qnn-eval-linux uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main From e791971c2e1ee6fddeac522df97116f3333b550f Mon Sep 17 00:00:00 2001 From: Chen Lai Date: Thu, 25 Sep 2025 11:49:04 -0700 Subject: [PATCH 3/8] debug --- .github/workflows/trunk.yml | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/.github/workflows/trunk.yml b/.github/workflows/trunk.yml index c6ec40cf6f7..35d8aa7a769 100644 --- a/.github/workflows/trunk.yml +++ b/.github/workflows/trunk.yml @@ -973,24 +973,24 @@ jobs: # Test llama2 PYTHON_EXECUTABLE=python bash .ci/scripts/test_llama.sh -model stories110M -build_tool "${BUILD_TOOL}" -mode "${MODE}" -dtype "${DTYPE}" -pt2e_quantize "${PT2E_QUANTIZE}" - # # this is for filtering out the qnn changes such that qnn jobs only triggered when the specific files are changed - # changes: - # runs-on: ubuntu-latest - # outputs: - # qnn: ${{ steps.filter.outputs.qnn }} - # steps: - # - uses: actions/checkout@v4 - # - uses: dorny/paths-filter@v3 - # id: filter - # with: - # filters: | - # qnn: - # - 'backends/qualcomm/**' - # - 'examples/qualcomm/**' - # - 'examples/models/llama/**' + # this is for filtering out the qnn changes such that qnn jobs only triggered when the specific files are changed + changes: + runs-on: ubuntu-latest + outputs: + qnn: ${{ steps.filter.outputs.qnn }} + steps: + - uses: actions/checkout@v4 + - uses: dorny/paths-filter@v3 + id: filter + with: + filters: | + qnn: + - 'backends/qualcomm/**' + - 'examples/qualcomm/**' + - 'examples/models/llama/**' test-static-llama-qnn-eval-linux: - # needs: changes # has dependency on changes jobs defined above + needs: changes # has dependency on changes jobs defined above if: needs.changes.outputs.qnn == 'true' name: test-static-llama-qnn-eval-linux uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main From bf7d5964806dbcd0ed5b937f80ec0b5ccc2e2ebb Mon Sep 17 00:00:00 2001 From: Chen Lai Date: Thu, 25 Sep 2025 11:57:11 -0700 Subject: [PATCH 4/8] debug --- .github/workflows/trunk.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/trunk.yml b/.github/workflows/trunk.yml index 35d8aa7a769..618b4227466 100644 --- a/.github/workflows/trunk.yml +++ b/.github/workflows/trunk.yml @@ -990,7 +990,7 @@ jobs: - 'examples/models/llama/**' test-static-llama-qnn-eval-linux: - needs: changes # has dependency on changes jobs defined above + # needs: changes # has dependency on changes jobs defined above if: needs.changes.outputs.qnn == 'true' name: test-static-llama-qnn-eval-linux uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main From e506e2bbfb056ee91365e7f75b4ad4ac31902244 Mon Sep 17 00:00:00 2001 From: Chen Lai Date: Thu, 25 Sep 2025 11:58:23 -0700 Subject: [PATCH 5/8] debug --- .github/workflows/trunk.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/trunk.yml b/.github/workflows/trunk.yml index 618b4227466..572d1028f15 100644 --- a/.github/workflows/trunk.yml +++ b/.github/workflows/trunk.yml @@ -991,7 +991,7 @@ jobs: test-static-llama-qnn-eval-linux: # needs: changes # has dependency on changes jobs defined above - if: needs.changes.outputs.qnn == 'true' + # if: needs.changes.outputs.qnn == 'true' name: test-static-llama-qnn-eval-linux uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main permissions: From 22f7f70e3fe73943b21ff49d24e55238f80d5e44 Mon Sep 17 00:00:00 2001 From: Chen Lai Date: Thu, 25 Sep 2025 12:00:18 -0700 Subject: [PATCH 6/8] add qcom changes --- backends/qualcomm/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/backends/qualcomm/README.md b/backends/qualcomm/README.md index 7c5853b3a6f..5545d90a790 100644 --- a/backends/qualcomm/README.md +++ b/backends/qualcomm/README.md @@ -12,6 +12,7 @@ A website version of the tutorial is [here](https://pytorch.org/executorch/main/ ## Delegate Options + Please check `generate_qnn_executorch_compiler_spec()` in [utils.py](utils/utils.py) for supported SoC and inference type. From e878e11656bb363ea873aeba78fd1f8f7444aa1b Mon Sep 17 00:00:00 2001 From: Chen Lai Date: Thu, 25 Sep 2025 12:00:39 -0700 Subject: [PATCH 7/8] add qcom changes --- .github/workflows/trunk.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/trunk.yml b/.github/workflows/trunk.yml index 572d1028f15..35d8aa7a769 100644 --- a/.github/workflows/trunk.yml +++ b/.github/workflows/trunk.yml @@ -990,8 +990,8 @@ jobs: - 'examples/models/llama/**' test-static-llama-qnn-eval-linux: - # needs: changes # has dependency on changes jobs defined above - # if: needs.changes.outputs.qnn == 'true' + needs: changes # has dependency on changes jobs defined above + if: needs.changes.outputs.qnn == 'true' name: test-static-llama-qnn-eval-linux uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main permissions: From da62098b3977467b70b99d80f280d003e30063b8 Mon Sep 17 00:00:00 2001 From: Chen Lai Date: Thu, 25 Sep 2025 12:21:32 -0700 Subject: [PATCH 8/8] restore qcom changes --- backends/qualcomm/README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/backends/qualcomm/README.md b/backends/qualcomm/README.md index 5545d90a790..7c5853b3a6f 100644 --- a/backends/qualcomm/README.md +++ b/backends/qualcomm/README.md @@ -12,7 +12,6 @@ A website version of the tutorial is [here](https://pytorch.org/executorch/main/ ## Delegate Options - Please check `generate_qnn_executorch_compiler_spec()` in [utils.py](utils/utils.py) for supported SoC and inference type.