Move to ProxyValue instead of FakeTensor weights. #14697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14697
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit a28b67d with merge base 07dcd95 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
@hsharma35 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D82605179. |
ethansfng
approved these changes
Sep 30, 2025
zonglinpeng
approved these changes
Sep 30, 2025
DrJessop
approved these changes
Sep 30, 2025
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Sep 30, 2025
Summary: With pt2, weights show up as ProxyValue instead of FakeTensor. This diff gets rid of old code that checks if weights are FakeTensor/ProxyValue and has logic to handle the two separately. Reviewed By: zonglinpeng, ethansfng, DrJessop Differential Revision: D82605179
hsharma35
force-pushed
the
export-D82605179
branch
from
29e137d to
95ad5b4
Compare
|
@hsharma35 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D82605179. |
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Sep 30, 2025
Summary: With pt2, weights show up as ProxyValue instead of FakeTensor. This diff gets rid of old code that checks if weights are FakeTensor/ProxyValue and has logic to handle the two separately. Reviewed By: zonglinpeng, ethansfng, DrJessop Differential Revision: D82605179
hsharma35
force-pushed
the
export-D82605179
branch
from
95ad5b4 to
95aba29
Compare
|
@hsharma35 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D82605179. |
hsharma35
force-pushed
the
export-D82605179
branch
from
95aba29 to
86afd19
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Oct 1, 2025
Summary: With pt2, weights show up as ProxyValue instead of FakeTensor. This diff gets rid of old code that checks if weights are FakeTensor/ProxyValue and has logic to handle the two separately. Reviewed By: zonglinpeng, ethansfng, DrJessop Differential Revision: D82605179
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Oct 1, 2025
Summary: With pt2, weights show up as ProxyValue instead of FakeTensor. This diff gets rid of old code that checks if weights are FakeTensor/ProxyValue and has logic to handle the two separately. Reviewed By: zonglinpeng, ethansfng, DrJessop Differential Revision: D82605179
hsharma35
force-pushed
the
export-D82605179
branch
from
86afd19 to
f80cfdb
Compare
Summary: With pt2, weights show up as ProxyValue instead of FakeTensor. This diff gets rid of old code that checks if weights are FakeTensor/ProxyValue and has logic to handle the two separately. Reviewed By: zonglinpeng, ethansfng, DrJessop Differential Revision: D82605179
hsharma35
force-pushed
the
export-D82605179
branch
from
f80cfdb to
a28b67d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: With pt2, weights show up as ProxyValue instead of FakeTensor. This diff gets rid of old code that checks if weights are FakeTensor/ProxyValue and has logic to handle the two separately.
Differential Revision: D82605179