From ec0ad2d452ae46f74e0e2e785e554910dd691b9f Mon Sep 17 00:00:00 2001 From: Jacob Szwejbka Date: Thu, 16 Oct 2025 22:40:45 -0700 Subject: [PATCH 1/3] text_llm_runner msvc --- extension/llm/runner/text_llm_runner.cpp | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/extension/llm/runner/text_llm_runner.cpp b/extension/llm/runner/text_llm_runner.cpp index 4e0bccdb781..5b5abf49f0b 100644 --- a/extension/llm/runner/text_llm_runner.cpp +++ b/extension/llm/runner/text_llm_runner.cpp @@ -116,8 +116,14 @@ Error TextLLMRunner::generate( /*bos=*/config.num_bos, /*eos=*/config.num_eos); - ET_CHECK_TK_OK_OR_RETURN_ERROR( - encode_res.error(), "Failed to encode prompt %s", prompt.c_str()); + if (!encode_res.ok()) { + ET_LOG( + Error, + "Failed to encode prompt %s. Tokenizers error code %d", + prompt.c_str(), + static_cast(encode_res.error())); + return Error::InvalidArgument; + } // encode the (string) prompt into tokens sequence std::vector prompt_tokens = encode_res.get(); @@ -230,8 +236,10 @@ Error TextLLMRunner::generate( Error TextLLMRunner::warmup(const std::string& prompt, int32_t max_new_tokens) { // Create a GenerationConfig for warmup - GenerationConfig config{ - .echo = false, .max_new_tokens = max_new_tokens, .warming = true}; + GenerationConfig config; + config.echo = false; + config.max_new_tokens = max_new_tokens; + config.warming = true; // Call generate with the warmup config Error err = generate(prompt, config); From 71993cf5ebc37004992cf42698cac27bd97d2707 Mon Sep 17 00:00:00 2001 From: Jacob Szwejbka Date: Sat, 18 Oct 2025 10:09:34 -0700 Subject: [PATCH 2/3] fix submodule --- extension/llm/tokenizers | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extension/llm/tokenizers b/extension/llm/tokenizers index b2a3d77d672..572e4073117 160000 --- a/extension/llm/tokenizers +++ b/extension/llm/tokenizers @@ -1 +1 @@ -Subproject commit b2a3d77d672d50f24d0ae7cd6df3b428469c2548 +Subproject commit 572e4073117cb8f8bb4651d2e738ae0d3a4f476a From c68d12d51679ac6f28c4b2e5ece35c91f68e68cb Mon Sep 17 00:00:00 2001 From: Jacob Szwejbka Date: Sat, 18 Oct 2025 10:13:01 -0700 Subject: [PATCH 3/3] fix submodule --- extension/llm/tokenizers | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extension/llm/tokenizers b/extension/llm/tokenizers index 572e4073117..b2a3d77d672 160000 --- a/extension/llm/tokenizers +++ b/extension/llm/tokenizers @@ -1 +1 @@ -Subproject commit 572e4073117cb8f8bb4651d2e738ae0d3a4f476a +Subproject commit b2a3d77d672d50f24d0ae7cd6df3b428469c2548