Skip to content

Conversation

@eigen-k
Copy link
Contributor

@eigen-k eigen-k commented Oct 22, 2025

Summary:
This diff reverts D83184528 by moving the ReplaceScalarWithTensorArgPass to the common section between helios and jarvis.

The mul.Scalar op is used in MTL models and Michael Maitland caught a performance degradation:
With mul.Scalar: P2003182852
vs without mul.Scalar P2003196850

Reviewed By: michaelmaitland, mcremon-meta

Differential Revision: D85256050

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 22, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15359

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures, 3 Unrelated Failures

As of commit a7ea048 with merge base a5428d3 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 22, 2025
@meta-codesync
Copy link

meta-codesync bot commented Oct 22, 2025

@eigen-k has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85256050.

@eigen-k eigen-k added the release notes: none Do not include this in the release notes label Oct 22, 2025
@michaelmaitland michaelmaitland self-requested a review October 22, 2025 17:48
…15359)

Summary:

This diff reverts D83184528 by moving the ReplaceScalarWithTensorArgPass to the common section between helios and jarvis.

The mul.Scalar op is used in MTL models and Michael Maitland  caught a performance degradation:
With mul.Scalar: P2003182852
vs without mul.Scalar P2003196850

Reviewed By: michaelmaitland, mcremon-meta

Differential Revision: D85256050
@meta-codesync meta-codesync bot merged commit 8f0e8a8 into pytorch:main Oct 22, 2025
137 of 150 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants