Move ReplaceScalarWithTensorArgPass, to the common section. #15359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff reverts D83184528 by moving the ReplaceScalarWithTensorArgPass to the common section between helios and jarvis.
The mul.Scalar op is used in MTL models and Michael Maitland caught a performance degradation:
With mul.Scalar: P2003182852
vs without mul.Scalar P2003196850
Reviewed By: michaelmaitland, mcremon-meta
Differential Revision: D85256050