Skip to content

Conversation

@DrJessop
Copy link
Contributor

Summary: Ensure modified is being correctly set for RemoveNopSliceOrViewOpPass

Differential Revision: D85815510

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15470

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 5 Unrelated Failures

As of commit 39783f5 with merge base e3b7eda (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 30, 2025
@meta-codesync
Copy link

meta-codesync bot commented Oct 30, 2025

@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85815510.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

DrJessop pushed a commit to DrJessop/executorch that referenced this pull request Oct 30, 2025
Summary:

Ensure modified is being correctly set for RemoveNopSliceOrViewOpPass

Differential Revision: D85815510
DrJessop pushed a commit to DrJessop/executorch that referenced this pull request Oct 31, 2025
Summary:

Ensure modified is being correctly set for RemoveNopSliceOrViewOpPass

Differential Revision: D85815510
DrJessop pushed a commit to DrJessop/executorch that referenced this pull request Oct 31, 2025
Summary:

Ensure modified is being correctly set for RemoveNopSliceOrViewOpPass

Reviewed By: abeakkas

Differential Revision: D85815510
DrJessop pushed a commit to DrJessop/executorch that referenced this pull request Nov 3, 2025
Summary:

Ensure modified is being correctly set for RemoveNopSliceOrViewOpPass. This diff also introduces a common base class that we can use for all remove ops passes.

Reviewed By: abeakkas

Differential Revision: D85815510
DrJessop pushed a commit to DrJessop/executorch that referenced this pull request Nov 3, 2025
Summary:

Ensure modified is being correctly set for RemoveNopSliceOrViewOpPass. This diff also introduces a common base class that we can use for all remove ops passes.

Reviewed By: abeakkas

Differential Revision: D85815510
DrJessop pushed a commit to DrJessop/executorch that referenced this pull request Nov 3, 2025
Summary:

Ensure modified is being correctly set for RemoveNopSliceOrViewOpPass. This diff also introduces a common base class that we can use for all remove ops passes.

Reviewed By: abeakkas

Differential Revision: D85815510
DrJessop pushed a commit to DrJessop/executorch that referenced this pull request Nov 4, 2025
Summary:

Ensure modified is being correctly set for RemoveNopSliceOrViewOpPass. This diff also introduces a common base class that we can use for all remove ops passes.

Reviewed By: abeakkas

Differential Revision: D85815510
Summary:

Ensure modified is being correctly set for RemoveNopSliceOrViewOpPass. This diff also introduces a common base class that we can use for all remove ops passes.

Reviewed By: abeakkas

Differential Revision: D85815510
@meta-codesync meta-codesync bot merged commit f4e1bd0 into pytorch:main Nov 4, 2025
138 of 145 checks passed
abhinaykukkadapu pushed a commit to abhinaykukkadapu/executorch that referenced this pull request Nov 6, 2025
Differential Revision: D85815510

Pull Request resolved: pytorch#15470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants