Skip to content

Conversation

@pytorchbot
Copy link
Collaborator

In text_prefiller.cpp prefill() we are updating the start_pos inside prefillChunk() as well as outside. This PR fixes this issue. Also updating llama main.cpp to take max_new_tokens.

Differential Revision: D86013259

Pull Request resolved: #15509

(cherry picked from commit a11d555)
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15531

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 2 Cancelled Jobs

As of commit 9f74ef6 with merge base e0dda90 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 3, 2025
@larryliu0820 larryliu0820 merged commit e6736a6 into release/1.0 Nov 3, 2025
120 of 124 checks passed
@larryliu0820 larryliu0820 deleted the cherry-pick-15509-by-pytorch_bot_bot_ branch November 3, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants