-
Notifications
You must be signed in to change notification settings - Fork 722
Use PTEFile class in serialize_pte_binary #15801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh/lucylq/126/base
Are you sure you want to change the base?
Conversation
Take in a PTE file for serialization instead of program, mutable_segments, named_data segments separately. Differential Revision: [D86908241](https://our.internmc.facebook.com/intern/diff/D86908241/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15801
Note: Links to docs will display an error until the docs builds have been completed. ❌ 11 New Failures, 5 Unrelated FailuresAs of commit 3253a87 with merge base 7600df8 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
Take in a PTE file for serialization instead of program, mutable_segments, named_data segments separately. Differential Revision: [D86908241](https://our.internmc.facebook.com/intern/diff/D86908241/) [ghstack-poisoned]
| get_common_executorch_program, | ||
| ) | ||
| from executorch.exir._serialize import _serialize_pte_binary | ||
| from executorch.exir._serialize import _PTEFile, _serialize_pte_binary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why _PTEFile but not PTEFile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is PTEFile supposed to be private only?
Stack from ghstack (oldest at bottom):
Take in a PTE file for serialization instead of program, mutable_segments, named_data segments separately.
Differential Revision: D86908241