Skip to content

custom comparator support in calculate_numeric_gap #15969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2025
Merged

custom comparator support in calculate_numeric_gap #15969

merged 1 commit into from
Dec 2, 2025
+97 −39

Conversation

@Gasoonjia
Copy link
Contributor

@Gasoonjia Gasoonjia commented Nov 25, 2025

Summary: Enable users to define their own metrics for numeric gap.

Differential Revision: D87840446

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 25, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15969

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ffb03ca with merge base 3ce840c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 25, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 25, 2025

@Gasoonjia has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87840446.

@Gasoonjia Gasoonjia mentioned this pull request Nov 25, 2025
Open
winskuo-quic
winskuo-quic reviewed Nov 25, 2025
View reviewed changes
Copy link
Collaborator

@winskuo-quic winskuo-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for supporting this feature and providing users more flexibility!

devtools/inspector/_inspector.py
Args:
distance: The metrics the inspector will use for gap calculation. Should be one of "MSE", "L1" and "SNR".
distance: The metrics the inspector will use for gap calculation. Can be either:
- A string: one of "MSE", "L1", or "SNR" for built-in comparators.
Copy link
Collaborator

@winskuo-quic winskuo-quic Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be - A string: one of "MSE", "L1", "SNR", or user-defined comparators?

Copy link
Contributor Author

@Gasoonjia Gasoonjia Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i separated the bulit-in comparators and custom comparators into two lines

facebook-github-bot pushed a commit that referenced this pull request Nov 25, 2025
@Gasoonjia @facebook-github-bot
custom comparator support in calculate_numeric_gap (#15969)
68cde50 
Summary:

Enable users to define their own metrics for numeric gap.

Differential Revision: D87840446
facebook-github-bot pushed a commit that referenced this pull request Dec 1, 2025
@Gasoonjia @facebook-github-bot
custom comparator support in calculate_numeric_gap (#15969)
406a4e7 
Summary:

Enable users to define their own metrics for numeric gap.

Differential Revision: D87840446
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@Gasoonjia @facebook-github-bot
custom comparator support in calculate_numeric_gap (#15969)
ffb03ca 
Summary:

Enable users to define their own metrics for numeric gap.

Differential Revision: D87840446
@meta-codesync meta-codesync bot merged commit 1864fb0 into main Dec 2, 2025
166 of 168 checks passed
@meta-codesync meta-codesync bot deleted the export-D87840446 branch December 2, 2025 00:28
AdrianLundell pushed a commit to AdrianLundell/executorch that referenced this pull request Dec 2, 2025
@Gasoonjia @AdrianLundell
custom comparator support in calculate_numeric_gap
c432972 
Differential Revision: D87840446

Pull Request resolved: pytorch#15969
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kimishpatel kimishpatel kimishpatel approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820

+1 more reviewer

@winskuo-quic winskuo-quic winskuo-quic left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Gasoonjia @kimishpatel @winskuo-quic