-
Notifications
You must be signed in to change notification settings - Fork 751
Arm backend: Replace ±inf and FP limit values with ±255.0 #15976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm backend: Replace ±inf and FP limit values with ±255.0 #15976
Conversation
- Rename ReplaceInfValuesPass -> ReplaceInfAndLimitValuesPass
- Extend to rewrite torch.finfo(torch.float32).{min,max} to ±255.0
to avoid generating TOSA RESCALE shifts < 2 (invalid per spec)
Change-Id: I749f7c28090c1e994ce27b19944db4c57f3b517d
Signed-off-by: Yufeng Shi <yufeng.shi@arm.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15976
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 1 Pending, 1 Unrelated FailureAs of commit d8a44d6 with merge base e38734e ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@SS-JIA mind taking a quick look since this moves a file? Just to be sure this doesn't break any buck2 stuff. |
|
@metascroy mind taking a quick look since this moves a file? Just to be sure this doesn't break any buck2 stuff. |
|
@metascroy has imported this pull request. If you are a Meta employee, you can view this in D88396358. |
|
This passes internal testing |
Change-Id: I749f7c28090c1e994ce27b19944db4c57f3b517d
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai