Skip to content

Conversation

@YufengShi-dudu
Copy link
Collaborator

@YufengShi-dudu YufengShi-dudu commented Nov 25, 2025

  • Rename ReplaceInfValuesPass -> ReplaceInfAndLimitValuesPass
  • Extend to rewrite torch.finfo(torch.float32).{min,max} to ±255.0 to avoid generating TOSA RESCALE shifts < 2 (invalid per spec)

Change-Id: I749f7c28090c1e994ce27b19944db4c57f3b517d

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

- Rename ReplaceInfValuesPass -> ReplaceInfAndLimitValuesPass
- Extend to rewrite torch.finfo(torch.float32).{min,max} to ±255.0
  to avoid generating TOSA RESCALE shifts < 2 (invalid per spec)

Change-Id: I749f7c28090c1e994ce27b19944db4c57f3b517d
Signed-off-by: Yufeng Shi <yufeng.shi@arm.com>
@YufengShi-dudu YufengShi-dudu added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Nov 25, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15976

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 1 Pending, 1 Unrelated Failure

As of commit d8a44d6 with merge base e38734e (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 25, 2025
@Sebastian-Larsson
Copy link
Collaborator

@SS-JIA mind taking a quick look since this moves a file? Just to be sure this doesn't break any buck2 stuff.

@zingo
Copy link
Collaborator

zingo commented Dec 4, 2025

@metascroy mind taking a quick look since this moves a file? Just to be sure this doesn't break any buck2 stuff.

@meta-codesync
Copy link

meta-codesync bot commented Dec 4, 2025

@metascroy has imported this pull request. If you are a Meta employee, you can view this in D88396358.

@metascroy
Copy link
Contributor

This passes internal testing

@Sebastian-Larsson Sebastian-Larsson merged commit 4014597 into pytorch:main Dec 5, 2025
297 of 298 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants