Skip to content

Fix -Wimplicit-const-int-float-conversion error. #15982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −4
Open

Fix -Wimplicit-const-int-float-conversion error. #15982

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions backends/cadence/vision/kernels/kernels.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
#include <algorithm>
#include <cstring>
#include <limits>
#include <numeric>

namespace impl {
namespace vision {
Expand All @@ -25,10 +24,10 @@ void* allocate_temp_memory(KernelRuntimeContext& ctx, size_t size) {
// Quantize a fp32 value to an int8_t/uint8_t value
template <typename T>
T quantize(const float x, float scale, int32_t zero_point) {
constexpr float min_val = std::numeric_limits<T>::min();
constexpr float max_val = std::numeric_limits<T>::max();
constexpr float kMinValue = static_cast<float>(std::numeric_limits<T>::min());
constexpr float kMaxValue = static_cast<float>(std::numeric_limits<T>::max());
float tmp = roundf(x * scale + zero_point);
return std::max(std::min(tmp, max_val), min_val);
return std::max(std::min(tmp, kMaxValue), kMinValue);
}

// Quantize an fp32 array to an int8_t/uint8_t array
Expand Down
Loading