Skip to content

Conversation

@DrJessop
Copy link
Contributor

@DrJessop DrJessop commented Dec 1, 2025

Summary:
Updated

  • ReplacePermuteWithTransposePass
  • ReplaceRepeatWithCatPass
  • ReplaceConstantPadNdWithSlicePass
  • ReplaceConvolutionOptionalArgsWithConcreteArgsPass

Also, fixed some bugs in conv1d. The meta kernel was not checking some basic assertions about groups, and the test was making a weight tensor with the wrong shape (out channels should come before in channels).

Reviewed By: hsharma35

Differential Revision: D86919809

Summary:
Updated
- ReplacePermuteWithTransposePass
- ReplaceRepeatWithCatPass
- ReplaceConstantPadNdWithSlicePass
- ReplaceConvolutionOptionalArgsWithConcreteArgsPass

Also, fixed some bugs in conv1d. The meta kernel was not checking some basic assertions about groups, and the test was making a weight tensor with the wrong shape (out channels should come before in channels).

Reviewed By: hsharma35

Differential Revision: D86919809
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 1, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16026

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Pending

As of commit e64451a with merge base a47a122 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 1, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 1, 2025

@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86919809.

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync bot merged commit 6903f28 into pytorch:main Dec 2, 2025
145 of 160 checks passed
AdrianLundell pushed a commit to AdrianLundell/executorch that referenced this pull request Dec 2, 2025
Differential Revision: D86919809

Pull Request resolved: pytorch#16026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants