Arm backend: Add fold_quantize option to tester#18005
Conversation
* Enables tests to be run with fold_quantize = False when required * This is used when you do not want convert_pt2e to fold constants * Temporary solution to enable testing of StaticCache in INT8 Signed-off-by: Tom Allsop <tom.allsop@arm.com> Change-Id: Ib25ea3949fc5f539c1a0a15565c3cbfe5099b9a1
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18005
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 1 PendingAs of commit 949e14e with merge base 122fdef ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Pull request overview
This PR adds a fold_quantize option to the Arm backend test pipeline infrastructure, allowing tests to optionally disable constant folding during quantization (convert_pt2e). This is described as a temporary solution to enable testing of StaticCache in INT8 where you don't want convert_pt2e to fold constants.
Changes:
- Adds a
fold_quantizeparameter toArmQuantizeinquantize.pyand threads it through toquantize_with_submodules - Adds
fold_quantizeparameter toquantize_with_submodulesinarm_quantizer.pyand passes it toconvert_pt2e - Propagates the
fold_quantizeoption through multiple pipeline classes intest_pipeline.py
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
backends/arm/test/tester/quantize.py |
Extends ArmQuantize with fold_quantize parameter, passes it to quantize_with_submodules |
backends/arm/quantizer/arm_quantizer.py |
Adds fold_quantize parameter to quantize_with_submodules, forwards to convert_pt2e |
backends/arm/test/tester/test_pipeline.py |
Threads fold_quantize through TosaPipelineINT, EthosUPipelineINTBase, EthosU55PipelineINT, EthosU85PipelineINT, QuantizationPipeline, and TosaPipelineMI pipeline classes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zingo
left a comment
There was a problem hiding this comment.
Maybe fix the copilot name change fold_quantze -> fold_quantize already now?
Change-Id: Id2931f0a39a69a94d29b81729115fc54b765cde2
I have implemented CoPilot's suggestions, so the review is ready now |
|
Failing jobs are unrelated |
* Enables tests to be run with fold_quantize = False when required * This is used when you do not want convert_pt2e to fold constants * Temporary solution to enable testing of StaticCache in INT8 Change-Id: Ib25ea3949fc5f539c1a0a15565c3cbfe5099b9a1 cc @digantdesai @SS-JIA @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell --------- Signed-off-by: Tom Allsop <tom.allsop@arm.com>
Change-Id: Ib25ea3949fc5f539c1a0a15565c3cbfe5099b9a1
cc @digantdesai @SS-JIA @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell