Ensure that lifted tensor constants don't show up as inputs in emitted program #1897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1897
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit 4543504 with merge base 3164688 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53584903 |
tarun292
added a commit
that referenced
this pull request
Feb 8, 2024
…d program (#1897) Summary: Currently lifted tensor constants are showing up as inputs to the emitted program. This shouldn't be the case as they're embedded inside the program as constants and the user will not be passing these in as inputs. Differential Revision: D53584903
tarun292
force-pushed
the
export-D53584903
branch
from
814b9e9 to
be06acd
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53584903 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
…d program (#1897) Summary: Currently lifted tensor constants are showing up as inputs to the emitted program. This shouldn't be the case as they're embedded inside the program as constants and the user will not be passing these in as inputs. Reviewed By: angelayi Differential Revision: D53584903
facebook-github-bot
force-pushed
the
export-D53584903
branch
from
be06acd to
a90d7a3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53584903 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
…d program (#1897) Summary: Currently lifted tensor constants are showing up as inputs to the emitted program. This shouldn't be the case as they're embedded inside the program as constants and the user will not be passing these in as inputs. Reviewed By: angelayi Differential Revision: D53584903
facebook-github-bot
force-pushed
the
export-D53584903
branch
from
a90d7a3 to
13a1836
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53584903 |
tarun292
added a commit
that referenced
this pull request
Feb 8, 2024
…d program (#1897) Summary: Currently lifted tensor constants are showing up as inputs to the emitted program. This shouldn't be the case as they're embedded inside the program as constants and the user will not be passing these in as inputs. Reviewed By: angelayi Differential Revision: D53584903
tarun292
force-pushed
the
export-D53584903
branch
from
13a1836 to
8eaba6b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53584903 |
facebook-github-bot
force-pushed
the
export-D53584903
branch
from
8eaba6b to
ab94ee7
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 9, 2024
…d program (#1897) Summary: Currently lifted tensor constants are showing up as inputs to the emitted program. This shouldn't be the case as they're embedded inside the program as constants and the user will not be passing these in as inputs. Reviewed By: chakriu, angelayi Differential Revision: D53584903
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53584903 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 9, 2024
…d program (#1897) Summary: Currently lifted tensor constants are showing up as inputs to the emitted program. This shouldn't be the case as they're embedded inside the program as constants and the user will not be passing these in as inputs. Reviewed By: chakriu, angelayi Differential Revision: D53584903
facebook-github-bot
force-pushed
the
export-D53584903
branch
from
ab94ee7 to
d5db55e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53584903 |
tarun292
added a commit
that referenced
this pull request
Feb 9, 2024
…d program (#1897) Summary: Currently lifted tensor constants are showing up as inputs to the emitted program. This shouldn't be the case as they're embedded inside the program as constants and the user will not be passing these in as inputs. Reviewed By: chakriu, angelayi Differential Revision: D53584903
tarun292
force-pushed
the
export-D53584903
branch
from
d5db55e to
f5298a7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53584903 |
tarun292
added a commit
that referenced
this pull request
Feb 9, 2024
…d program (#1897) Summary: Currently lifted tensor constants are showing up as inputs to the emitted program. This shouldn't be the case as they're embedded inside the program as constants and the user will not be passing these in as inputs. Reviewed By: chakriu, angelayi Differential Revision: D53584903
tarun292
force-pushed
the
export-D53584903
branch
from
f5298a7 to
0bfa39e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53584903 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 9, 2024
…d program (#1897) Summary: Currently lifted tensor constants are showing up as inputs to the emitted program. This shouldn't be the case as they're embedded inside the program as constants and the user will not be passing these in as inputs. Reviewed By: chakriu, angelayi Differential Revision: D53584903
facebook-github-bot
force-pushed
the
export-D53584903
branch
from
0bfa39e to
8fc0f28
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53584903 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 9, 2024
…d program (#1897) Summary: Currently lifted tensor constants are showing up as inputs to the emitted program. This shouldn't be the case as they're embedded inside the program as constants and the user will not be passing these in as inputs. Reviewed By: chakriu, angelayi Differential Revision: D53584903
facebook-github-bot
force-pushed
the
export-D53584903
branch
from
8fc0f28 to
17eab50
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53584903 |
Contributor
|
@tarun292 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…d program (#1897) Summary: Currently lifted tensor constants are showing up as inputs to the emitted program. This shouldn't be the case as they're embedded inside the program as constants and the user will not be passing these in as inputs. Reviewed By: chakriu, angelayi Differential Revision: D53584903 Pulled By: tarun292
tarun292
force-pushed
the
export-D53584903
branch
from
17eab50 to
4543504
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53584903 |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Currently lifted tensor constants are showing up as inputs to the emitted program. This shouldn't be the case as they're embedded inside the program as constants and the user will not be passing these in as inputs.
Differential Revision: D53584903