From ddfba178c4e4e3e494f0bdad52072f1f131c99c8 Mon Sep 17 00:00:00 2001 From: Riandy Riandy Date: Fri, 20 Sep 2024 13:54:35 -0700 Subject: [PATCH] Fix broken images in docs (#5514) Summary: Pull Request resolved: https://github.com/pytorch/executorch/pull/5514 https://github.com/pytorch/executorch/pull/5475/ moved the images to static folder, https://github.com/pytorch/executorch/pull/5493 updated some of it but missed out on the delegate specific docs. This diff, fixes that by replacing the image URLs that are broken Reviewed By: cmodi-meta, svekars, kirklandsign Differential Revision: D63135522 fbshipit-source-id: 10071b0428c203eef38500852e64f71e13ec1315 (cherry picked from commit 7de3f818462b73da14dbf8ff2596b55fd04ae580) --- .../android/LlamaDemo/docs/delegates/mediatek_README.md | 4 ++-- .../android/LlamaDemo/docs/delegates/qualcomm_README.md | 2 +- .../android/LlamaDemo/docs/delegates/xnnpack_README.md | 2 +- .../apple_ios/LLaMA/docs/delegates/mps_README.md | 6 +++--- .../apple_ios/LLaMA/docs/delegates/xnnpack_README.md | 8 ++++---- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/examples/demo-apps/android/LlamaDemo/docs/delegates/mediatek_README.md b/examples/demo-apps/android/LlamaDemo/docs/delegates/mediatek_README.md index 44b7636060a..8010d79fc70 100644 --- a/examples/demo-apps/android/LlamaDemo/docs/delegates/mediatek_README.md +++ b/examples/demo-apps/android/LlamaDemo/docs/delegates/mediatek_README.md @@ -112,7 +112,7 @@ Before continuing forward, make sure to modify the tokenizer, token embedding, a Prior to deploying the files on device, make sure to modify the tokenizer, token embedding, and model file names in examples/mediatek/executor_runner/run_llama3_sample.sh reflect what was generated during the Export Llama Model step.

- +

In addition, create a sample_prompt.txt file with a prompt. This will be deployed to the device in the next step. @@ -150,7 +150,7 @@ adb shell ```

- +

## Reporting Issues diff --git a/examples/demo-apps/android/LlamaDemo/docs/delegates/qualcomm_README.md b/examples/demo-apps/android/LlamaDemo/docs/delegates/qualcomm_README.md index 1accc28a937..24e45de9b4b 100644 --- a/examples/demo-apps/android/LlamaDemo/docs/delegates/qualcomm_README.md +++ b/examples/demo-apps/android/LlamaDemo/docs/delegates/qualcomm_README.md @@ -221,7 +221,7 @@ popd If the app successfully run on your device, you should see something like below:

- +

## Reporting Issues diff --git a/examples/demo-apps/android/LlamaDemo/docs/delegates/xnnpack_README.md b/examples/demo-apps/android/LlamaDemo/docs/delegates/xnnpack_README.md index 754acba4b85..017f0464108 100644 --- a/examples/demo-apps/android/LlamaDemo/docs/delegates/xnnpack_README.md +++ b/examples/demo-apps/android/LlamaDemo/docs/delegates/xnnpack_README.md @@ -149,7 +149,7 @@ popd If the app successfully run on your device, you should see something like below:

- +

## Reporting Issues diff --git a/examples/demo-apps/apple_ios/LLaMA/docs/delegates/mps_README.md b/examples/demo-apps/apple_ios/LLaMA/docs/delegates/mps_README.md index 6b90da04671..0c0fd9a5366 100644 --- a/examples/demo-apps/apple_ios/LLaMA/docs/delegates/mps_README.md +++ b/examples/demo-apps/apple_ios/LLaMA/docs/delegates/mps_README.md @@ -95,19 +95,19 @@ Note: To access logs, link against the Debug build of the ExecuTorch runtime, i. For more details integrating and Running ExecuTorch on Apple Platforms, checkout this [link](https://pytorch.org/executorch/main/apple-runtime.html).

-iOS LLaMA App Swift PM +iOS LLaMA App Swift PM

Then select which ExecuTorch framework should link against which target.

-iOS LLaMA App Choosing package +iOS LLaMA App Choosing package

Click “Run” to build the app and run in on your iPhone. If the app successfully run on your device, you should see something like below:

-iOS LLaMA App mps +iOS LLaMA App mps

## Reporting Issues diff --git a/examples/demo-apps/apple_ios/LLaMA/docs/delegates/xnnpack_README.md b/examples/demo-apps/apple_ios/LLaMA/docs/delegates/xnnpack_README.md index f4f8a5cf17e..76a5cf448a4 100644 --- a/examples/demo-apps/apple_ios/LLaMA/docs/delegates/xnnpack_README.md +++ b/examples/demo-apps/apple_ios/LLaMA/docs/delegates/xnnpack_README.md @@ -95,25 +95,25 @@ Note: To access logs, link against the Debug build of the ExecuTorch runtime, i. For more details integrating and Running ExecuTorch on Apple Platforms, checkout this [link](https://pytorch.org/executorch/main/apple-runtime.html).

-iOS LLaMA App Swift PM +iOS LLaMA App Swift PM

Then select which ExecuTorch framework should link against which target.

-iOS LLaMA App Choosing package +iOS LLaMA App Choosing package

Click “Run” to build the app and run in on your iPhone. If the app successfully run on your device, you should see something like below:

-iOS LLaMA App +iOS LLaMA App

For Llava 1.5 models, you can select and image (via image/camera selector button) before typing prompt and send button.

-iOS LLaMA App +iOS LLaMA App

## Reporting Issues