Fix out of OOB error for ConversationHistory #5775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: When user clears chat history and then give a prompt, there is a OOB error. This occurs since `getRecentSavedTextMessages()` didn't check for an empty Message Arraylist. Pull Request resolved: #5770 Reviewed By: Riandy Differential Revision: D63659827 Pulled By: cmodi-meta fbshipit-source-id: 1e3157a8f1c17cb1e4b94f9ff7287b53a2b4f2af (cherry picked from commit f0662bb)
This was referenced Sep 30, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5775
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 26f5452 with merge base eecf74f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jackzhxng
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user clears chat history and then give a prompt, there is a OOB error. This occurs since
getRecentSavedTextMessages()didn't check for an empty Message Arraylist.