compiler.h changes for Windows MSVC support #6623

tarun292 · 2024-11-03T10:48:40Z

Differential Revision: D65328573

pytorch-bot · 2024-11-03T10:48:43Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6623

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 0677a48 with merge base 8a4e492 ():

NEW FAILURE - The following job has failed:

pull / test-binary-size-linux-gcc / linux-job (gh)
RuntimeError: Command docker exec -t 53d2caf383545f22278ee07b81591d09034a45ab60f7c053a0c04c966e1b31ac /exec failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-11-03T10:48:52Z

This pull request was exported from Phabricator. Differential Revision: D65328573

Summary: Pull Request resolved: #6623 Differential Revision: D65328573

facebook-github-bot · 2024-11-03T21:54:28Z

This pull request was exported from Phabricator. Differential Revision: D65328573

Summary: Pull Request resolved: #6623 Differential Revision: D65328573

facebook-github-bot · 2024-11-03T21:57:43Z

This pull request was exported from Phabricator. Differential Revision: D65328573

Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Differential Revision: D65328573

facebook-github-bot · 2024-11-03T23:55:57Z

This pull request was exported from Phabricator. Differential Revision: D65328573

Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Differential Revision: D65328573

facebook-github-bot · 2024-11-04T16:41:41Z

This pull request was exported from Phabricator. Differential Revision: D65328573

Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Differential Revision: D65328573

facebook-github-bot · 2024-11-04T16:44:51Z

This pull request was exported from Phabricator. Differential Revision: D65328573

Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Differential Revision: D65328573

facebook-github-bot · 2024-11-04T19:42:44Z

This pull request was exported from Phabricator. Differential Revision: D65328573

Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573

facebook-github-bot · 2024-11-04T22:03:31Z

This pull request was exported from Phabricator. Differential Revision: D65328573

Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573

facebook-github-bot · 2024-11-04T22:10:06Z

This pull request was exported from Phabricator. Differential Revision: D65328573

Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573

facebook-github-bot · 2024-11-04T22:12:08Z

This pull request was exported from Phabricator. Differential Revision: D65328573

malfet · 2024-11-04T22:12:49Z

kernels/prim_ops/register_prim_ops.cpp

          if (a.isInt() && b.isInt()) {
            const int64_t quot = a.toInt() / b.toInt();
-            if (std::signbit(a.toInt()) == std::signbit(b.toInt())) {
+            if ((a.toInt() < 0) == (b.toInt() < 0)) {


This feels unrelated to PR in question, is it?

Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573

facebook-github-bot · 2024-11-04T22:18:08Z

This pull request was exported from Phabricator. Differential Revision: D65328573

Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573

facebook-github-bot · 2024-11-04T22:29:10Z

This pull request was exported from Phabricator. Differential Revision: D65328573

Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573

facebook-github-bot · 2024-11-04T23:29:41Z

This pull request was exported from Phabricator. Differential Revision: D65328573

Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573

facebook-github-bot · 2024-11-05T04:35:28Z

This pull request was exported from Phabricator. Differential Revision: D65328573

Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573

chinazhangchao · 2024-11-25T08:33:36Z

runtime/platform/compiler.h

+// There currently doesn't seem to be a great way to do this in Windows and
+// given that weak linkage is not really critical on Windows, we'll just leave
+// it as a stub.
+#define ET_WEAK


Hi, we are adding Windows x64 Build Support #6979. I use .\install_requirements.bat --pybind xnnpack to build on windows. And we encountered duplicate symbol problem.

I investigated and found that windows didn't support weak symbol. Do you have some insights how to resolve this?

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 3, 2024

facebook-github-bot added the fb-exported label Nov 3, 2024

facebook-github-bot pushed a commit that referenced this pull request Nov 3, 2024

compiler.h changes for Windows MSVC support (#6623)

ea21c7a

Summary: Pull Request resolved: #6623 Differential Revision: D65328573

facebook-github-bot force-pushed the export-D65328573 branch from 6b11ec8 to ea21c7a Compare November 3, 2024 21:54

facebook-github-bot force-pushed the export-D65328573 branch from ea21c7a to 19aa228 Compare November 3, 2024 21:57

facebook-github-bot pushed a commit that referenced this pull request Nov 3, 2024

compiler.h changes for Windows MSVC support (#6623)

19aa228

Summary: Pull Request resolved: #6623 Differential Revision: D65328573

facebook-github-bot pushed a commit that referenced this pull request Nov 3, 2024

compiler.h changes for Windows MSVC support (#6623)

72fbf8b

Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Differential Revision: D65328573

facebook-github-bot force-pushed the export-D65328573 branch from 19aa228 to 72fbf8b Compare November 3, 2024 23:55

tarun292 force-pushed the export-D65328573 branch from 72fbf8b to 80b0f91 Compare November 4, 2024 16:41

tarun292 added a commit that referenced this pull request Nov 4, 2024

compiler.h changes for Windows MSVC support (#6623)

80b0f91

Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Differential Revision: D65328573

facebook-github-bot pushed a commit that referenced this pull request Nov 4, 2024

compiler.h changes for Windows MSVC support (#6623)

0f120f4

Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Differential Revision: D65328573

facebook-github-bot force-pushed the export-D65328573 branch from 80b0f91 to 0f120f4 Compare November 4, 2024 16:44

tarun292 added a commit that referenced this pull request Nov 4, 2024

compiler.h changes for Windows MSVC support (#6623)

953b1bc

Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Differential Revision: D65328573

tarun292 force-pushed the export-D65328573 branch from 0f120f4 to 953b1bc Compare November 4, 2024 19:42

dbort approved these changes Nov 4, 2024

View reviewed changes

tarun292 added a commit that referenced this pull request Nov 4, 2024

compiler.h changes for Windows MSVC support (#6623)

3f58d24

Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573

facebook-github-bot force-pushed the export-D65328573 branch from 953b1bc to 689673c Compare November 4, 2024 22:03

facebook-github-bot force-pushed the export-D65328573 branch from 689673c to be2de10 Compare November 4, 2024 22:09

facebook-github-bot force-pushed the export-D65328573 branch from be2de10 to e42c91a Compare November 4, 2024 22:11

malfet reviewed Nov 4, 2024

View reviewed changes

facebook-github-bot force-pushed the export-D65328573 branch from e42c91a to 641c52e Compare November 4, 2024 22:17

tarun292 added a commit that referenced this pull request Nov 4, 2024

compiler.h changes for Windows MSVC support (#6623)

cfa7e73

Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573

tarun292 added a commit that referenced this pull request Nov 4, 2024

compiler.h changes for Windows MSVC support (#6623)

914091f

Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573

facebook-github-bot force-pushed the export-D65328573 branch from 641c52e to bb5008b Compare November 4, 2024 22:28

tarun292 added a commit that referenced this pull request Nov 4, 2024

compiler.h changes for Windows MSVC support (#6623)

2e44faf

Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573

tarun292 added a commit that referenced this pull request Nov 4, 2024

compiler.h changes for Windows MSVC support (#6623)

20ebc02

Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573

facebook-github-bot force-pushed the export-D65328573 branch from bb5008b to 86fb5fb Compare November 4, 2024 23:29

tarun292 added a commit that referenced this pull request Nov 4, 2024

compiler.h changes for Windows MSVC support (#6623)

62fa5ef

Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573

tarun292 added a commit that referenced this pull request Nov 4, 2024

compiler.h changes for Windows MSVC support (#6623)

71638c1

Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573

compiler.h changes for Windows MSVC support (#6623)

0677a48

Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573

tarun292 force-pushed the export-D65328573 branch from 86fb5fb to 0677a48 Compare November 5, 2024 04:35

tarun292 added a commit that referenced this pull request Nov 5, 2024

compiler.h changes for Windows MSVC support (#6623)

f495579

Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573

facebook-github-bot merged commit 11d1742 into main Nov 5, 2024
39 of 41 checks passed

facebook-github-bot deleted the export-D65328573 branch November 5, 2024 07:55

chinazhangchao reviewed Nov 25, 2024

View reviewed changes

compiler.h changes for Windows MSVC support #6623

compiler.h changes for Windows MSVC support #6623

Uh oh!

Conversation

tarun292 commented Nov 3, 2024

Uh oh!

pytorch-bot bot commented Nov 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6623

❌ 1 New Failure

Uh oh!

facebook-github-bot commented Nov 3, 2024

Uh oh!

facebook-github-bot commented Nov 3, 2024

Uh oh!

facebook-github-bot commented Nov 3, 2024

Uh oh!

facebook-github-bot commented Nov 3, 2024

Uh oh!

facebook-github-bot commented Nov 4, 2024

Uh oh!

facebook-github-bot commented Nov 4, 2024

Uh oh!

facebook-github-bot commented Nov 4, 2024

Uh oh!

facebook-github-bot commented Nov 4, 2024

Uh oh!

facebook-github-bot commented Nov 4, 2024

Uh oh!

facebook-github-bot commented Nov 4, 2024

Uh oh!

malfet Nov 4, 2024

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Nov 4, 2024

Uh oh!

facebook-github-bot commented Nov 4, 2024

Uh oh!

facebook-github-bot commented Nov 4, 2024

Uh oh!

facebook-github-bot commented Nov 5, 2024

Uh oh!

Uh oh!

chinazhangchao Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pytorch-bot bot commented Nov 3, 2024 •

edited

Loading