Skip to content

Fix lint and dependency issues in D67108845 #7294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix lint and dependency issues in D67108845 #7294

wants to merge 1 commit into from

Conversation

@YIWENX14
Copy link
Contributor

Differential Revision: D67108845

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 11, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7294

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 7c1ea19 with merge base 957259e (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 11, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67108845

YIWENX14 added a commit to YIWENX14/executorch that referenced this pull request Dec 11, 2024
@YIWENX14 @facebook-github-bot
Fix lint and dependency issues in D67108845 (pytorch#7294)
2b9ba10 
Summary:
pytorchbot label "topic: not user facing"



1. fix linter issue
2. remove `pyre_extensions` dependency

Differential Revision: D67108845
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67108845

YIWENX14 added a commit to YIWENX14/executorch that referenced this pull request Dec 11, 2024
@YIWENX14 @facebook-github-bot
Fix lint and dependency issues in D67108845 (pytorch#7294)
d598352 
Summary:
pytorchbot label "topic: not user facing"



1. fix linter issue
2. remove `pyre_extensions` dependency

Differential Revision: D67108845
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67108845

@kirklandsign
Copy link
Contributor 

>>> Lint for devtools/bundled_program/test/test_bundle_data.py:

  Warning (UFMT) format
    Run `lintrunner -a` to apply this patch.

    You can run `lintrunner -a` to apply this patch.

    74  74 |             bundled_program.serialize_to_schema().program,
    75  75 |             bytes(_serialize_pte_binary(executorch_program.executorch_program)),
    76  76 |         )
    76     |-        
        77 |+
    78  78 |     def test_bundled_program_from_pte(self) -> None:
    79  79 |         executorch_program, method_test_suites = get_common_executorch_program()
    80  80 | 
--------------------------------------------------------------------------------
    84  84 |                 f.write(executorch_program.buffer)
    85  85 | 
    86  86 |             bundled_program = BundledProgram(
    86     |-                executorch_program=None,
    87     |-                method_test_suites=method_test_suites,
        87 |+                executorch_program=None,
        88 |+                method_test_suites=method_test_suites,
    89  89 |                 pte_file_path=executorch_model_path,
    90  90 |             )
    91  91 |

@YIWENX14 @facebook-github-bot
Fix lint and dependency issues in D67108845 (pytorch#7294)
7c1ea19 
Summary:
pytorchbot label "topic: not user facing"




1. fix linter issue
2. remove `pyre_extensions` dependency

Differential Revision: D67108845
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67108845

@kirklandsign
Copy link
Contributor

@pytorchbot label "topic: not user facing"

@YIWENX14 YIWENX14 closed this Dec 12, 2024
@YIWENX14 YIWENX14 deleted the export-D67108845 branch December 12, 2024 18:53
@YIWENX14
Copy link
Contributor Author

The issues are already fixed by PR #7296. Deleting the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@YIWENX14 @facebook-github-bot @kirklandsign @malfet