diff --git a/.ci/scripts/unittest-buck2.sh b/.ci/scripts/unittest-buck2.sh index 59b8ac6ccd2..efbf386ffa0 100755 --- a/.ci/scripts/unittest-buck2.sh +++ b/.ci/scripts/unittest-buck2.sh @@ -8,9 +8,7 @@ set -eux # TODO: expand this to //... # TODO: can't query cadence & vulkan backends -# TODO: can't query //kernels/prim_ops because of a cpp_unittest and -# broken code in shim to read oss.folly_cxx_tests. Sending fix but it -# needs to propagate and we need a submodule update. +# TODO: can't query //kernels/prim_ops because of non-buckified stuff in OSS. buck2 query "//backends/apple/... + //backends/example/... + \ //backends/mediatek/... + //backends/test/... + //backends/transforms/... + \ //backends/xnnpack/... + //configurations/... + //kernels/aten/... + \ @@ -20,7 +18,9 @@ buck2 query "//backends/apple/... + //backends/example/... + \ UNBUILDABLE_OPTIMIZED_OPS_REGEX="gelu|fft_r2c|log_softmax" BUILDABLE_OPTIMIZED_OPS=$(buck2 query //kernels/optimized/cpu/... | grep -E -v $UNBUILDABLE_OPTIMIZED_OPS_REGEX) -BUILDABLE_KERNELS_PRIM_OPS_TARGETS=$(buck2 query //kernels/prim_ops/... | grep -v prim_ops_test_py) +# TODO: build prim_ops_test_cpp again once supported_features works in +# OSS buck. +BUILDABLE_KERNELS_PRIM_OPS_TARGETS=$(buck2 query //kernels/prim_ops/... | grep -v prim_ops_test) # TODO: expand the covered scope of Buck targets. # //runtime/kernel/... is failing because //third-party:torchgen_files's shell script can't find python on PATH. # //runtime/test/... requires Python torch, which we don't have in our OSS buck setup. diff --git a/kernels/test/targets.bzl b/kernels/test/targets.bzl index 7afc9aa1a59..18ab0ac2e28 100644 --- a/kernels/test/targets.bzl +++ b/kernels/test/targets.bzl @@ -37,7 +37,7 @@ def define_common_targets(): ], fbcode_exported_deps = [ "//common/gtest:gtest", - ], + ] if not runtime.is_oss else [], xplat_exported_deps = [ "//third-party/googletest:gtest_main", ], @@ -68,7 +68,7 @@ def define_common_targets(): fbcode_exported_deps = [ "//common/init:init", "//common/gtest:gtest", - ], + ] if not runtime.is_oss else [], xplat_exported_deps = [ "//xplat/folly:init_init", "//third-party/googletest:gtest_main",