From ddae737270f163010ecdd56d50158a6558d9c085 Mon Sep 17 00:00:00 2001 From: Nathanael See Date: Tue, 25 Mar 2025 10:47:30 -0700 Subject: [PATCH] [BE][ET-VK] update clone to use layout gen TSIA @pytorchbot label "topic: not user facing" Differential Revision: [D71825480](https://our.internmc.facebook.com/intern/diff/D71825480/) [ghstack-poisoned] --- backends/vulkan/runtime/graph/ops/glsl/clone.glsl | 11 ++++------- backends/vulkan/runtime/graph/ops/glsl/clone.yaml | 1 + 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/backends/vulkan/runtime/graph/ops/glsl/clone.glsl b/backends/vulkan/runtime/graph/ops/glsl/clone.glsl index 64def8d7000..fb804d5e1c7 100644 --- a/backends/vulkan/runtime/graph/ops/glsl/clone.glsl +++ b/backends/vulkan/runtime/graph/ops/glsl/clone.glsl @@ -12,12 +12,9 @@ layout(std430) buffer; -layout(set = 0, binding = 0, ${IMAGE_FORMAT[DTYPE]}) uniform PRECISION restrict writeonly ${IMAGE_T[NDIM][DTYPE]} image_out; -layout(set = 0, binding = 1) uniform PRECISION sampler3D image_in; - -layout(set = 0, binding = 2) uniform PRECISION restrict OutLimits { - ivec3 out_limits; -}; +${layout_declare_tensor(B, "w", "t_out", DTYPE, STORAGE)} +${layout_declare_tensor(B, "r", "t_in", DTYPE, STORAGE)} +${layout_declare_ubo(B, "ivec3", "out_limits")} layout(local_size_x_id = 0, local_size_y_id = 1, local_size_z_id = 2) in; @@ -26,5 +23,5 @@ void main() { if (any(greaterThanEqual(pos, out_limits))) { return; } - imageStore(image_out, pos, texelFetch(image_in, pos, 0)); + imageStore(t_out, pos, load_texel(t_in, pos)); } diff --git a/backends/vulkan/runtime/graph/ops/glsl/clone.yaml b/backends/vulkan/runtime/graph/ops/glsl/clone.yaml index 5dbce0e9d8d..1fdbf506bfd 100644 --- a/backends/vulkan/runtime/graph/ops/glsl/clone.yaml +++ b/backends/vulkan/runtime/graph/ops/glsl/clone.yaml @@ -2,6 +2,7 @@ clone: parameter_names_with_default_values: DTYPE: float NDIM: 3 + STORAGE: texture3d generate_variant_forall: DTYPE: - VALUE: half