From 3e3a8fc6b6790587d432f8322dc155567be2930d Mon Sep 17 00:00:00 2001 From: Anthony Shoumikhin Date: Tue, 25 Mar 2025 13:30:37 -0700 Subject: [PATCH 1/9] Update test_ios_ci.sh to use the app from executorch-examples repo --- .ci/scripts/test_ios_ci.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ci/scripts/test_ios_ci.sh b/.ci/scripts/test_ios_ci.sh index 50c6448d4b2..7138be74490 100755 --- a/.ci/scripts/test_ios_ci.sh +++ b/.ci/scripts/test_ios_ci.sh @@ -7,7 +7,7 @@ set -e -APP_PATH="examples/demo-apps/apple_ios/ExecuTorchDemo/ExecuTorchDemo" +APP_PATH="executorch-examples/apple/ExecuTorchDemo/ExecuTorchDemo" MODEL_NAME="mv3" SIMULATOR_NAME="executorch" From 0e2640e8f0d46e1df92c76df4120a5eddaaf7427 Mon Sep 17 00:00:00 2001 From: Anthony Shoumikhin Date: Tue, 25 Mar 2025 13:32:56 -0700 Subject: [PATCH 2/9] Update apple.yml --- .github/workflows/apple.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/apple.yml b/.github/workflows/apple.yml index 0436a914dd0..41911ed0a72 100644 --- a/.github/workflows/apple.yml +++ b/.github/workflows/apple.yml @@ -73,6 +73,9 @@ jobs: export ARTIFACTS_DIR_NAME=artifacts-to-be-uploaded + # Clone iOS Demo App + git clone https://github.com/pytorch-labs/executorch-examples.git --depth 1 + # Build and test iOS Demo App PYTHON_EXECUTABLE=python ${CONDA_RUN} --no-capture-output \ .ci/scripts/test_ios_ci.sh "${ARTIFACTS_DIR_NAME}" From 486c8354178e90d95be90c9cf712999f8ff3a648 Mon Sep 17 00:00:00 2001 From: Anthony Shoumikhin Date: Tue, 25 Mar 2025 13:49:45 -0700 Subject: [PATCH 3/9] Update apple.yml --- .github/workflows/apple.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/apple.yml b/.github/workflows/apple.yml index 41911ed0a72..0436a914dd0 100644 --- a/.github/workflows/apple.yml +++ b/.github/workflows/apple.yml @@ -73,9 +73,6 @@ jobs: export ARTIFACTS_DIR_NAME=artifacts-to-be-uploaded - # Clone iOS Demo App - git clone https://github.com/pytorch-labs/executorch-examples.git --depth 1 - # Build and test iOS Demo App PYTHON_EXECUTABLE=python ${CONDA_RUN} --no-capture-output \ .ci/scripts/test_ios_ci.sh "${ARTIFACTS_DIR_NAME}" From e5303cccdd3bf56344f01dc421b4fff697b52f95 Mon Sep 17 00:00:00 2001 From: Anthony Shoumikhin Date: Tue, 25 Mar 2025 13:50:56 -0700 Subject: [PATCH 4/9] Update test_ios_ci.sh --- .ci/scripts/test_ios_ci.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.ci/scripts/test_ios_ci.sh b/.ci/scripts/test_ios_ci.sh index 7138be74490..e87dbec8444 100755 --- a/.ci/scripts/test_ios_ci.sh +++ b/.ci/scripts/test_ios_ci.sh @@ -34,6 +34,10 @@ say() { echo -e "\033[1m\n\t** $1 **\n\033[0m" } +say "Cloning the Demo App" + +git clone --depth 1 https://github.com/pytorch-labs/executorch-examples.git + say "Installing CoreML Backend Requirements" ./backends/apple/coreml/scripts/install_requirements.sh From cc2435229330d41469998718bfd7cb6f760e3e43 Mon Sep 17 00:00:00 2001 From: Huy Do Date: Wed, 26 Mar 2025 13:35:17 -0700 Subject: [PATCH 5/9] Update test_ios_ci.sh to try to use GITHUB_TOKEN to clone repo --- .ci/scripts/test_ios_ci.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ci/scripts/test_ios_ci.sh b/.ci/scripts/test_ios_ci.sh index e87dbec8444..a2ea33f4ec6 100755 --- a/.ci/scripts/test_ios_ci.sh +++ b/.ci/scripts/test_ios_ci.sh @@ -36,7 +36,7 @@ say() { say "Cloning the Demo App" -git clone --depth 1 https://github.com/pytorch-labs/executorch-examples.git +git clone --depth 1 https://${GITHUB_TOKEN}:github.com/pytorch-labs/executorch-examples.git say "Installing CoreML Backend Requirements" From e23096a7fe9c16e34a3b883e05899e0c660572a5 Mon Sep 17 00:00:00 2001 From: Huy Do Date: Wed, 26 Mar 2025 13:54:31 -0700 Subject: [PATCH 6/9] Use SECRET_GITHUB_TOKEN --- .ci/scripts/test_ios_ci.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ci/scripts/test_ios_ci.sh b/.ci/scripts/test_ios_ci.sh index a2ea33f4ec6..aad366dc3eb 100755 --- a/.ci/scripts/test_ios_ci.sh +++ b/.ci/scripts/test_ios_ci.sh @@ -36,7 +36,7 @@ say() { say "Cloning the Demo App" -git clone --depth 1 https://${GITHUB_TOKEN}:github.com/pytorch-labs/executorch-examples.git +git clone --depth 1 https://${SECRET_GITHUB_TOKEN}:github.com/pytorch-labs/executorch-examples.git say "Installing CoreML Backend Requirements" From 1b065e3a8d4ef42488cd8e05d9b92ebfe06926a8 Mon Sep 17 00:00:00 2001 From: Huy Do Date: Wed, 26 Mar 2025 14:27:43 -0700 Subject: [PATCH 7/9] Try to pass GITHUB_TOKEN to Nova job --- .github/workflows/apple.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/apple.yml b/.github/workflows/apple.yml index 0436a914dd0..56b30a69f6f 100644 --- a/.github/workflows/apple.yml +++ b/.github/workflows/apple.yml @@ -52,7 +52,7 @@ jobs: submodules: 'recursive' ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }} timeout: 90 - secrets-env: BUILD_CERTIFICATE_BASE64 EXECUTORCH_DEMO_BUILD_PROVISION_PROFILE_BASE64 KEYCHAIN_PASSWORD + secrets-env: BUILD_CERTIFICATE_BASE64 EXECUTORCH_DEMO_BUILD_PROVISION_PROFILE_BASE64 KEYCHAIN_PASSWORD GITHUB_TOKEN upload-artifact: ios-demo-app script: | set -eux From e3420d4a4d6b73fbfb5bb83970b2cc90a8fada80 Mon Sep 17 00:00:00 2001 From: Huy Do Date: Wed, 26 Mar 2025 15:18:00 -0700 Subject: [PATCH 8/9] Revert testing change --- .ci/scripts/test_ios_ci.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ci/scripts/test_ios_ci.sh b/.ci/scripts/test_ios_ci.sh index aad366dc3eb..e87dbec8444 100755 --- a/.ci/scripts/test_ios_ci.sh +++ b/.ci/scripts/test_ios_ci.sh @@ -36,7 +36,7 @@ say() { say "Cloning the Demo App" -git clone --depth 1 https://${SECRET_GITHUB_TOKEN}:github.com/pytorch-labs/executorch-examples.git +git clone --depth 1 https://github.com/pytorch-labs/executorch-examples.git say "Installing CoreML Backend Requirements" From 5f08bc82325f1dcc9daa40747cf590007b6d4025 Mon Sep 17 00:00:00 2001 From: Huy Do Date: Wed, 26 Mar 2025 15:18:18 -0700 Subject: [PATCH 9/9] Revert testing change --- .github/workflows/apple.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/apple.yml b/.github/workflows/apple.yml index 56b30a69f6f..0436a914dd0 100644 --- a/.github/workflows/apple.yml +++ b/.github/workflows/apple.yml @@ -52,7 +52,7 @@ jobs: submodules: 'recursive' ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }} timeout: 90 - secrets-env: BUILD_CERTIFICATE_BASE64 EXECUTORCH_DEMO_BUILD_PROVISION_PROFILE_BASE64 KEYCHAIN_PASSWORD GITHUB_TOKEN + secrets-env: BUILD_CERTIFICATE_BASE64 EXECUTORCH_DEMO_BUILD_PROVISION_PROFILE_BASE64 KEYCHAIN_PASSWORD upload-artifact: ios-demo-app script: | set -eux